Issue 329383003: Disable the App Info Dialog from displaying for the Genius app

Issue 329383003: Disable the App Info Dialog from displaying for the Genius app (Closed)

Created:
6 years, 6 months ago by sashab

Modified:
6 years, 6 months ago

Reviewers:
benwells

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Disable the App Info Dialog from displaying for the Genius app Disable the App Info Dialog from being selectable for the Genius app, which shows as a 'Get Help' link in the app launcher (and doesn't have a proper description/proper metadata). BUG=383713 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276709

Patch Set 1 #

Patch Set 2 : Switched to a special case instead of making it the norm #

Total comments: 1

Patch Set 3 : Added bug ref #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	chrome/browser/ui/app_list/app_context_menu.cc	View	1 2	2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

benwells

lgtm https://codereview.chromium.org/329383003/diff/20001/chrome/browser/ui/app_list/app_context_menu.cc File chrome/browser/ui/app_list/app_context_menu.cc (right): https://codereview.chromium.org/329383003/diff/20001/chrome/browser/ui/app_list/app_context_menu.cc#newcode121 chrome/browser/ui/app_list/app_context_menu.cc:121: // TODO(sashab): Update the metadata for these apps ...

6 years, 6 months ago (2014-06-12 07:11:14 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sashab@chromium.org/329383003/40001

6 years, 6 months ago (2014-06-12 07:49:18 UTC) #7

Message was sent while issue was closed.

Change committed as 276709

Expand Messages | Collapse Messages