Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: chrome/browser/ui/app_list/app_context_menu.cc

Issue 329383003: Disable the App Info Dialog from displaying for the Genius app (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added bug ref Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/app_list/app_context_menu.cc
diff --git a/chrome/browser/ui/app_list/app_context_menu.cc b/chrome/browser/ui/app_list/app_context_menu.cc
index 12d4a9a35c8f90bd94a1911e293309be08c60d92..59e6073b6fe3a2fde885f6a9be10dbb8e3f5cce9 100644
--- a/chrome/browser/ui/app_list/app_context_menu.cc
+++ b/chrome/browser/ui/app_list/app_context_menu.cc
@@ -7,6 +7,7 @@
#include "base/bind.h"
#include "base/command_line.h"
#include "chrome/app/chrome_command_ids.h"
+#include "chrome/browser/chromeos/genius_app/app_id.h"
#include "chrome/browser/extensions/context_menu_matcher.h"
#include "chrome/browser/extensions/menu_manager.h"
#include "chrome/browser/prefs/incognito_mode_prefs.h"
@@ -116,9 +117,12 @@ ui::MenuModel* AppContextMenu::GetMenuModel() {
IDS_NEW_TAB_APP_CREATE_SHORTCUT);
}
- // Don't display the app info dialog for the web store app.
+ // Don't display the app info dialog for the Store app or the Genius app.
+ // TODO(sashab): Update the metadata for these apps so their dialogs can be
+ // re-enabled (see crbug.com/383713).
if (controller_->CanDoShowAppInfoFlow() &&
- app_id_ != extension_misc::kWebStoreAppId) {
+ app_id_ != extension_misc::kWebStoreAppId &&
+ app_id_ != genius_app::kGeniusAppId) {
menu_model_->AddItemWithStringId(SHOW_APP_INFO,
IDS_APP_CONTEXT_MENU_SHOW_INFO);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698