Issue 329253005: Qualify the generated includes in platform.

Issue 329253005: Qualify the generated includes in platform. (Closed)

Created:
6 years, 6 months ago by c.shu

Modified:
6 years, 6 months ago

Reviewers:
tkent, haraken, brettw, skal, abarth-chromium

CC:
blink-reviews, jamesr, krit, vikasa, jzern, skal, jbroman, danakj, Rik, urvang (Google), Stephen Chennney, pdr., do_not_use, Nils Barth (inactive)

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Qualify the generated includes in platform. BUG=381876 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175997

Patch Set 1 #

Patch Set 2 : Fix gn build #

Patch Set 3 : Fix Mac build #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -27 lines)			Patch
M	Source/platform/BUILD.gn	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/platform/blink_platform.gyp	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	Source/platform/blink_platform_tests.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/fonts/FontCache.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/platform/fonts/FontDescription.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/fonts/FontDescription.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/fonts/FontFallbackList.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/fonts/linux/FontPlatformDataLinuxHarfBuzz.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/fonts/mac/FontCacheMac.mm	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/fonts/mac/SimpleFontDataMac.mm	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/fonts/opentype/OpenTypeSanitizer.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/fonts/win/FontCacheSkiaWin.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/graphics/gpu/DrawingBuffer.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/graphics/gpu/DrawingBufferTest.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/image-decoders/webp/WEBPImageDecoder.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/image-decoders/webp/WEBPImageDecoderTest.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/scroll/ScrollbarTheme.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/scroll/ScrollbarThemeAura.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/scroll/ScrollbarThemeMacCommon.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/scroll/ScrollbarThemeMock.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

c.shu

On 2014/06/11 20:54:14, skal wrote: > [lgtm for the WebP part] thanks, skal.

6 years, 6 months ago (2014-06-11 20:56:45 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/329253005/40001

6 years, 6 months ago (2014-06-12 00:13:51 UTC) #8

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...

6 years, 6 months ago (2014-06-12 04:04:49 UTC) #9

Message was sent while issue was closed.

Change committed as 175997

Expand Messages | Collapse Messages