[DeprecateAs] if call addEventListener or removeEventListener without enough arguments

Source/bindings/templates/methods.cpp

Index: Source/bindings/templates/methods.cpp
diff --git a/Source/bindings/templates/methods.cpp b/Source/bindings/templates/methods.cpp
index 9affae262495d67d4fd6fdb460ec011387010573..2e218d31b6d387d82110ade52c76f075455f6e2d 100644
--- a/Source/bindings/templates/methods.cpp
+++ b/Source/bindings/templates/methods.cpp
@@ -21,8 +21,7 @@ static void {{method.name}}{{method.overload_index}}Method{{world_suffix}}(const
     CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
     {% endif %}
     {# Security checks #}
-    {# FIXME: change to method.is_check_security_for_window #}
-    {% if interface_name == 'EventTarget' %}
+    {% if is_check_security_for_window %}

[haraken, 2014/06/12 02:15:45]

It doesn't make sense to introduce [CheckSecurity=Window]. The EventTarget is
checking security against Frame, not Window. Look at line 26 calling
shouldAllowAccessTo*Frame*().

The only difference between EventTarget and other interfaces that have
[CheckSecurity=Frame] is the way to retrieve a frame. EventTarget retrieves a
frame via impl->toDOMWindow()->frame(), whereas other interfaces retrieves a
frame via impl->frame().

Shall we add EventTarget::frame() so that we can merge the two code?

[Nils Barth (inactive), 2014/06/12 02:51:52]

It's slightly trickier:
EventTarget also has a !window->document() check.

[CheckSecurity=Frame] also affects other code, like
security_check_functions
(indexedSecurityCheck and namedSecurityCheck)
and instanceTemplate->SetAccessCheckCallbacks
...which also need to be handled differently.

Cleaning this up is a bit involved, so I've removed this part of the CL and
opened a separate bug:
Eliminate special handling of EventTarget and EventListener
https://code.google.com/p/chromium/issues/detail?id=383699

     if (DOMWindow* window = impl->toDOMWindow()) {
         if (!BindingSecurity::shouldAllowAccessToFrame(info.GetIsolate(), window->frame(), exceptionState)) {
             {{throw_from_exception_state(method)}};