[DeprecateAs] if call addEventListener or removeEventListener without enough arguments

Source/bindings/templates/methods.cpp

 {##############################################################################}
 {% macro generate_method(method, world_suffix) %}
 {% filter conditional(method.conditional_string) %}
 static void {{method.name}}{{method.overload_index}}Method{{world_suffix}}(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     {# Local variables #}
     {% if method.has_exception_state %}
     ExceptionState exceptionState(ExceptionState::ExecutionContext, "{{method.name}}", "{{interface_name}}", info.Holder(), info.GetIsolate());
     {% endif %}
     {# Overloaded methods have length checked during overload resolution #}
     {% if method.number_of_required_arguments and not method.overload_index %}
     if (UNLIKELY(info.Length() < {{method.number_of_required_arguments}})) {
         {{throw_minimum_arity_type_error(method, method.number_of_required_arguments)}};
         return;
     }
     {% endif %}
     {% if not method.is_static %}
     {{cpp_class}}* impl = {{v8_class}}::toNative(info.Holder());
     {% endif %}
     {% if method.is_custom_element_callbacks %}
     CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
     {% endif %}
     {# Security checks #}
-    {# FIXME: change to method.is_check_security_for_window #}
-    {% if interface_name == 'EventTarget' %}
+    {% if is_check_security_for_window %}

[haraken, 2014/06/12 02:15:45]

It doesn't make sense to introduce [CheckSecurity=Window]. The EventTarget is
checking security against Frame, not Window. Look at line 26 calling
shouldAllowAccessTo*Frame*().

The only difference between EventTarget and other interfaces that have
[CheckSecurity=Frame] is the way to retrieve a frame. EventTarget retrieves a
frame via impl->toDOMWindow()->frame(), whereas other interfaces retrieves a
frame via impl->frame().

Shall we add EventTarget::frame() so that we can merge the two code?

[Nils Barth (inactive), 2014/06/12 02:51:52]

It's slightly trickier:
EventTarget also has a !window->document() check.

[CheckSecurity=Frame] also affects other code, like
security_check_functions
(indexedSecurityCheck and namedSecurityCheck)
and instanceTemplate->SetAccessCheckCallbacks
...which also need to be handled differently.

Cleaning this up is a bit involved, so I've removed this part of the CL and
opened a separate bug:
Eliminate special handling of EventTarget and EventListener
https://code.google.com/p/chromium/issues/detail?id=383699

     if (DOMWindow* window = impl->toDOMWindow()) {
         if (!BindingSecurity::shouldAllowAccessToFrame(info.GetIsolate(), window->frame(), exceptionState)) {
             {{throw_from_exception_state(method)}};
             return;
         }
         if (!window->document())
             return;
     }
     {% elif method.is_check_security_for_frame %}
     if (!BindingSecurity::shouldAllowAccessToFrame(info.GetIsolate(), impl->frame(), exceptionState)) {
@@ skipping 517 matching lines @@
     {% endif %}
     {{constructor.cpp_type}} impl = {{cpp_class}}::createForJSConstructor({{constructor.argument_list | join(', ')}});
     {% if is_constructor_raises_exception %}
     if (exceptionState.throwIfNeeded())
         return;
     {% endif %}
 
     {{generate_constructor_wrapper(constructor) | indent}}
 }
 {% endmacro %}