Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 329223004: [DeprecateAs] if call addEventListener or removeEventListener without enough arguments Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Move ext attr to interface Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/v8_interface.py
diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py
index db90d4c09eb55a64bbd26bdd3f54021a24b4685f..3174794578079f20713752de8caada6d771ab47d 100644
--- a/Source/bindings/scripts/v8_interface.py
+++ b/Source/bindings/scripts/v8_interface.py
@@ -90,11 +90,19 @@ def generate_interface(interface):
# [ActiveDOMObject]
is_active_dom_object = 'ActiveDOMObject' in extended_attributes
- # [CheckSecurity]
- is_check_security = 'CheckSecurity' in extended_attributes
- if is_check_security:
+ # [CheckSecurity=Frame]
+ is_check_security_for_frame = has_extended_attribute_value(
+ interface, 'CheckSecurity', 'Frame')
+ if is_check_security_for_frame:
includes.add('bindings/v8/BindingSecurity.h')
+ # [CheckSecurity=Window]
+ is_check_security_for_window = has_extended_attribute_value(
+ interface, 'CheckSecurity', 'Window')
+ if is_check_security_for_window:
+ includes.update(['bindings/v8/BindingSecurity.h',
+ 'core/frame/DOMWindow.h'])
+
# [DependentLifetime]
is_dependent_lifetime = 'DependentLifetime' in extended_attributes
@@ -151,7 +159,8 @@ def generate_interface(interface):
'interface_name': interface.name,
'is_active_dom_object': is_active_dom_object,
'is_audio_buffer': is_audio_buffer,
- 'is_check_security': is_check_security,
+ 'is_check_security_for_frame': is_check_security_for_frame,
+ 'is_check_security_for_window': is_check_security_for_window,
'is_dependent_lifetime': is_dependent_lifetime,
'is_document': is_document,
'is_event_target': inherits_interface(interface.name, 'EventTarget'),

Powered by Google App Engine
This is Rietveld 408576698