[DeprecateAs] if call addEventListener or removeEventListener without enough arguments

Source/bindings/scripts/v8_methods.py

Index: Source/bindings/scripts/v8_methods.py
diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py
index b50ba604efeda5d30d6904c14ab2371aec03b82c..856590bfc60e4fbcbb33ff342e08b52fe91a2f52 100644
--- a/Source/bindings/scripts/v8_methods.py
+++ b/Source/bindings/scripts/v8_methods.py
@@ -77,10 +77,12 @@ def generate_method(interface, method):
     if is_call_with_script_arguments:
         includes.update(['bindings/v8/ScriptCallStackFactory.h',
                          'core/inspector/ScriptArguments.h'])
-    is_call_with_script_state = has_extended_attribute_value(method, 'CallWith', 'ScriptState')
+    is_call_with_script_state = has_extended_attribute_value(
+        method, 'CallWith', 'ScriptState')
     if is_call_with_script_state:
         includes.add('bindings/v8/ScriptState.h')
-    is_check_security_for_node = 'CheckSecurity' in extended_attributes
+    is_check_security_for_node = has_extended_attribute_value(
+        method, 'CheckSecurity', 'Node')
     if is_check_security_for_node:
         includes.add('bindings/v8/BindingSecurity.h')
     is_custom_element_callbacks = 'CustomElementCallbacks' in extended_attributes
@@ -89,9 +91,9 @@ def generate_method(interface, method):
 
     has_event_listener_argument = any(
         argument for argument in arguments
-        if argument.idl_type.name == 'EventListener')
+        if argument.idl_type.name == 'EventListenerOrNull')

[haraken, 2014/06/12 04:23:23]

Shouldn't this be:

  if argument.idl_type.name == 'EventListener' or argument.idl_type.name ==
'EventListenerOrNull'

?

(BTW, I was assuming that we have idl_type.name and idl_type.nullable
separately. idl_type.name stores the type name (without "OrNull") and
idl_type.nullable stores whether the type is nullable or not.)

[Nils Barth (inactive), 2014/06/12 04:55:40]

The only use of EventListener is as a nullable type, so
argument.idl_type.name == 'EventListener'
is dead code.

Python note:
For multiple matches, use |in|:
if argument.idl_type.name in ('EventListener', 'EventListenerOrNull'):
No, the type name includes nullability:
http://heycam.github.io/webidl/#idl-nullable-type
"""
The type name of a nullable type is the concatenation of the type name of the
inner type T and the string “OrNull”.
"""

We have IdlType.base_type to hold the base type of nullable/array/etc. types;
(in the spec, for nullable this is "inner type", for array this is "element
type", but we're not distinguishing these currently)
I'm using IdlType.name here to be tighter, as this is an ugly special case.

     is_check_security_for_frame = (
-        'CheckSecurity' in interface.extended_attributes and
+        has_extended_attribute_value(interface, 'CheckSecurity', 'Frame') and
         'DoNotCheckSecurity' not in extended_attributes)
     is_raises_exception = 'RaisesException' in extended_attributes
 
@@ -115,7 +117,7 @@ def generate_method(interface, method):
         'idl_type': idl_type.base_type,
         'has_event_listener_argument': has_event_listener_argument,
         'has_exception_state':
-            has_event_listener_argument or
+            interface.name == 'EventTarget' or  # FIXME: merge with is_check_security_for_frame http://crbug.com/383699
             is_raises_exception or
             is_check_security_for_frame or
             any(argument for argument in arguments
@@ -172,7 +174,7 @@ def generate_argument(interface, method, argument, index):
         'has_default': 'Default' in extended_attributes,
         'has_event_listener_argument': any(
             argument_so_far for argument_so_far in method.arguments[:index]
-            if argument_so_far.idl_type.name == 'EventListener'),
+            if argument_so_far.idl_type.name == 'EventListenerOrNull'),
         'has_type_checking_interface':
             (has_extended_attribute_value(interface, 'TypeChecking', 'Interface') or
              has_extended_attribute_value(method, 'TypeChecking', 'Interface')) and
@@ -206,7 +208,7 @@ def generate_argument(interface, method, argument, index):
 def cpp_value(interface, method, number_of_arguments):
     def cpp_argument(argument):
         idl_type = argument.idl_type
-        if idl_type.name == 'EventListener':
+        if idl_type.name == 'EventListenerOrNull':
             if (interface.name == 'EventTarget' and
                 method.name == 'removeEventListener'):
                 # FIXME: remove this special case by moving get() into