Source/bindings/scripts/v8_interface.py - Issue 329223004: [DeprecateAs] if call addEventListener or removeEventListener without enough arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 329223004: [DeprecateAs] if call addEventListener or removeEventListener without enough arguments Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Test update/simplification Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/node-legacy-event-listener-expected.txt ('k') | Source/bindings/scripts/v8_methods.py » ('j') | Source/bindings/scripts/v8_methods.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/scripts/v8_interface.py

diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py

index db90d4c09eb55a64bbd26bdd3f54021a24b4685f..7004aff9bb365b99c3512b4dde7d1de8c6a83382 100644

--- a/Source/bindings/scripts/v8_interface.py

+++ b/Source/bindings/scripts/v8_interface.py

@@ -90,9 +90,10 @@ def generate_interface(interface):

# [ActiveDOMObject]

is_active_dom_object = 'ActiveDOMObject' in extended_attributes

- # [CheckSecurity]

- is_check_security = 'CheckSecurity' in extended_attributes

- if is_check_security:

+ # [CheckSecurity=Frame]

+ is_check_security_for_frame = has_extended_attribute_value(

+ interface, 'CheckSecurity', 'Frame')

+ if is_check_security_for_frame:

includes.add('bindings/v8/BindingSecurity.h')

# [DependentLifetime]

@@ -151,7 +152,7 @@ def generate_interface(interface):

'interface_name': interface.name,

'is_active_dom_object': is_active_dom_object,

'is_audio_buffer': is_audio_buffer,

- 'is_check_security': is_check_security,

+ 'is_check_security_for_frame': is_check_security_for_frame,

'is_dependent_lifetime': is_dependent_lifetime,

'is_document': is_document,

'is_event_target': inherits_interface(interface.name, 'EventTarget'),