Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 329143007: Fix some SVGFonts compilation errors (Closed)

Created:
6 years, 6 months ago by rwlbuis
Modified:
6 years, 6 months ago
Reviewers:
pdr.
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, eae+blinkwatch, fs, apavlov+blink_chromium.org, kouhei+svg_chromium.org, rune+blink, krit, blink-reviews-css, blink-reviews-dom_chromium.org, dglazkov+blink, jchaffraix+rendering, zoltan1, sof, gyuyoung.kim_webkit.org, darktears, blink-reviews-rendering, leviw+renderwatch, ed+blinkwatch_opera.com, f(malita), Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix some SVGFonts compilation errors Fix some SVGFonts compilation errors that are seen when turning off the compile time flag SVG_FONTS. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175985

Patch Set 1 #

Patch Set 2 : Avoid using platform #

Patch Set 3 : Rebase against ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M Source/core/css/CSSFontFace.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/custom/CustomElement.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGResources.cpp View 3 chunks +8 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGTextRunRenderingContext.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/svg/SVGDocumentExtensions.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rwlbuis
Just a fix for building with SVG Fonts turned off. There is one problem left ...
6 years, 6 months ago (2014-06-11 18:51:01 UTC) #1
pdr.
On 2014/06/11 18:51:01, rwlbuis wrote: > Just a fix for building with SVG Fonts turned ...
6 years, 6 months ago (2014-06-11 18:52:04 UTC) #2
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 6 months ago (2014-06-11 19:05:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/329143007/40001
6 years, 6 months ago (2014-06-11 19:06:14 UTC) #4
rwlbuis
On 2014/06/11 18:52:04, pdr wrote: > On 2014/06/11 18:51:01, rwlbuis wrote: > > Just a ...
6 years, 6 months ago (2014-06-11 19:20:27 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 05:27:38 UTC) #6
Message was sent while issue was closed. 
Change committed as 175985

Powered by Google App Engine
This is Rietveld 408576698