Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2073)

Unified Diff: Source/modules/mediastream/RTCVoidRequestImpl.h

Issue 329093002: Allow PeerConnection to be garbage collected after close(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Use ref counting for pending activity for a async operations. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/mediastream/RTCVoidRequestImpl.h
diff --git a/Source/modules/mediastream/RTCVoidRequestImpl.h b/Source/modules/mediastream/RTCVoidRequestImpl.h
index afea015c0070f6cd6570c893becfd034df746610..232b19c0ae84650b6d70bfb3118b5c5987084659 100644
--- a/Source/modules/mediastream/RTCVoidRequestImpl.h
+++ b/Source/modules/mediastream/RTCVoidRequestImpl.h
@@ -37,11 +37,12 @@
namespace WebCore {
class RTCErrorCallback;
+class RTCPeerConnection;
class VoidCallback;
class RTCVoidRequestImpl FINAL : public RTCVoidRequest, public ActiveDOMObject {
public:
- static PassRefPtr<RTCVoidRequestImpl> create(ExecutionContext*, PassOwnPtr<VoidCallback>, PassOwnPtr<RTCErrorCallback>);
+ static PassRefPtr<RTCVoidRequestImpl> create(ExecutionContext*, RTCPeerConnection*, PassOwnPtr<VoidCallback>, PassOwnPtr<RTCErrorCallback>);
virtual ~RTCVoidRequestImpl();
// RTCVoidRequest
@@ -52,12 +53,15 @@ public:
virtual void stop() OVERRIDE;
private:
- RTCVoidRequestImpl(ExecutionContext*, PassOwnPtr<VoidCallback>, PassOwnPtr<RTCErrorCallback>);
+ RTCVoidRequestImpl(ExecutionContext*, RTCPeerConnection*, PassOwnPtr<VoidCallback>, PassOwnPtr<RTCErrorCallback>);
void clear();
OwnPtr<VoidCallback> m_successCallback;
OwnPtr<RTCErrorCallback> m_errorCallback;
+
+ // TODO - BEFORE COMMIT: Raw pointer OK?
+ RTCPeerConnection* m_requester;
};
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698