Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h - Issue 329093002: Allow PeerConnection to be garbage collected after close().

Unified Diff: Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h

Issue 329093002: Allow PeerConnection to be garbage collected after close(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Use ref counting for pending activity for a async operations. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/mediastream/RTCPeerConnection.cpp ('K') | « Source/modules/mediastream/RTCPeerConnection.cpp ('k') | Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h

diff --git a/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h b/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h

index 80ebe8cb5d758e96c727c14bf247760112eab364..12da5f3814fea6dcdaaeabb8ff55dd0d0aa7ccc0 100644

--- a/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h

+++ b/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h

@@ -48,7 +48,7 @@ class RTCSessionDescriptionCallback;

class RTCSessionDescriptionRequestImpl FINAL : public RTCSessionDescriptionRequest, public ActiveDOMObject {

public:

- static PassRefPtr<RTCSessionDescriptionRequestImpl> create(ExecutionContext*, PassOwnPtr<RTCSessionDescriptionCallback>, PassOwnPtr<RTCErrorCallback>);

+ static PassRefPtr<RTCSessionDescriptionRequestImpl> create(ExecutionContext*, RTCPeerConnection*, PassOwnPtr<RTCSessionDescriptionCallback>, PassOwnPtr<RTCErrorCallback>);

virtual ~RTCSessionDescriptionRequestImpl();

virtual void requestSucceeded(const blink::WebRTCSessionDescription&) OVERRIDE;

@@ -58,12 +58,15 @@ public:

virtual void stop() OVERRIDE;

private:

- RTCSessionDescriptionRequestImpl(ExecutionContext*, PassOwnPtr<RTCSessionDescriptionCallback>, PassOwnPtr<RTCErrorCallback>);

+ RTCSessionDescriptionRequestImpl(ExecutionContext*, RTCPeerConnection*, PassOwnPtr<RTCSessionDescriptionCallback>, PassOwnPtr<RTCErrorCallback>);

void clear();

OwnPtr<RTCSessionDescriptionCallback> m_successCallback;

OwnPtr<RTCErrorCallback> m_errorCallback;

+ // TODO - BEFORE COMMIT: Raw pointer OK?

+ RTCPeerConnection* m_requester;

haraken 2014/06/13 01:23:00 I guess this needs to be a RefPtr. Otherwise, the

Henrik Grunell 2014/06/13 07:50:46 Well, it should have been prevented with the ref c

};

} // namespace WebCore