Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1599)

Unified Diff: Source/modules/mediastream/RTCStatsRequestImpl.h

Issue 329093002: Allow PeerConnection to be garbage collected after close(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Use ref counting for pending activity for a async operations. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/mediastream/RTCStatsRequestImpl.h
diff --git a/Source/modules/mediastream/RTCStatsRequestImpl.h b/Source/modules/mediastream/RTCStatsRequestImpl.h
index eb3b08e8c7c5f59c81b89141c004d1b3ffec4083..588db015feb3b6a284578d8de307dfb33c338eec 100644
--- a/Source/modules/mediastream/RTCStatsRequestImpl.h
+++ b/Source/modules/mediastream/RTCStatsRequestImpl.h
@@ -35,11 +35,12 @@
namespace WebCore {
class MediaStreamTrack;
+class RTCPeerConnection;
class RTCStatsCallback;
class RTCStatsRequestImpl FINAL : public RTCStatsRequest, public ActiveDOMObject {
public:
- static PassRefPtr<RTCStatsRequestImpl> create(ExecutionContext*, PassOwnPtr<RTCStatsCallback>, PassRefPtr<MediaStreamTrack>);
+ static PassRefPtr<RTCStatsRequestImpl> create(ExecutionContext*, RTCPeerConnection*, PassOwnPtr<RTCStatsCallback>, PassRefPtr<MediaStreamTrack>);
virtual ~RTCStatsRequestImpl();
virtual PassRefPtrWillBeRawPtr<RTCStatsResponseBase> createResponse() OVERRIDE;
@@ -52,12 +53,15 @@ public:
virtual void stop() OVERRIDE;
private:
- RTCStatsRequestImpl(ExecutionContext*, PassOwnPtr<RTCStatsCallback>, PassRefPtr<MediaStreamTrack>);
+ RTCStatsRequestImpl(ExecutionContext*, RTCPeerConnection*, PassOwnPtr<RTCStatsCallback>, PassRefPtr<MediaStreamTrack>);
void clear();
OwnPtr<RTCStatsCallback> m_successCallback;
RefPtr<MediaStreamComponent> m_component;
+
+ // TODO - BEFORE COMMIT: Raw pointer OK?
+ RTCPeerConnection* m_requester;
};
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698