Make HistoryQuickProvider::DeleteMatch also delete the underlying URL from the History Database.

Make HistoryQuickProvider::DeleteMatch also delete the underlying URL from the History Database.

BUG=383272
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276777

[engedy, 2014-06-11 11:42:39]

@Peter: Please take a look.

(Apologies for sending so many random CLs your way these days.)

[Peter Kasting, 2014-06-11 18:32:34]

https://codereview.chromium.org/329073003/diff/20001/chrome/browser/autocompl...
File chrome/browser/autocomplete/history_quick_provider.cc (right):

https://codereview.chromium.org/329073003/diff/20001/chrome/browser/autocompl...
chrome/browser/autocomplete/history_quick_provider.cc:93: void
HistoryQuickProvider::DeleteMatch(const AutocompleteMatch& match) {
This function seems like it now just does what HistoryProvider::DeleteMatch()
does (except for deleting from the in-memory index, which ought not to be
necessary, since deleting from the main index should cause that to happen
automatically).

Can you just eliminate this method entirely and verify (preferably in the test)
that the base class method causes the item to get deleted from both the main and
in-memory DBs?

[engedy, 2014-06-12 08:48:00]

https://codereview.chromium.org/329073003/diff/20001/chrome/browser/autocompl...
File chrome/browser/autocomplete/history_quick_provider.cc (right):

https://codereview.chromium.org/329073003/diff/20001/chrome/browser/autocompl...
chrome/browser/autocomplete/history_quick_provider.cc:93: void
HistoryQuickProvider::DeleteMatch(const AutocompleteMatch& match) {
On 2014/06/11 18:32:34, Peter Kasting wrote:
> This function seems like it now just does what HistoryProvider::DeleteMatch()
> does (except for deleting from the in-memory index, which ought not to be
> necessary, since deleting from the main index should cause that to happen
> automatically).
> 
> Can you just eliminate this method entirely and verify (preferably in the
test)
> that the base class method causes the item to get deleted from both the main
and
> in-memory DBs?

Done. You are entirely correct. I actually feel kinda bad for not noticing this
after having been hacking on history code for so long. /o\

[Peter Kasting, 2014-06-12 17:27:33]

LGTM

[engedy, 2014-06-12 17:50:27]

The CQ bit was checked by engedy@chromium.org

[commit-bot: I haz the power, 2014-06-12 17:53:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/engedy@chromium.org/329073003/40001

[commit-bot: I haz the power, 2014-06-12 19:41:35]

Change committed as 276777

[Mark P, 2014-06-12 20:14:09]

On 2014/06/12 19:41:35, I haz the power (commit-bot) wrote:
> Change committed as 276777

Funny how deleting code fixes this bug. :-)

--mark