chrome/browser/autocomplete/history_quick_provider.cc - Issue 329073003: Make HistoryQuickProvider::DeleteMatch also delete the underlying URL from the History Database.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/history_quick_provider.cc

Issue 329073003: Make HistoryQuickProvider::DeleteMatch also delete the underlying URL from the History Database. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/history_quick_provider.h ('k') | chrome/browser/autocomplete/history_quick_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/history_quick_provider.cc

diff --git a/chrome/browser/autocomplete/history_quick_provider.cc b/chrome/browser/autocomplete/history_quick_provider.cc

index 1391ca47b256e7ca294f22faf2f9495d870992ad..bd6d9975fb471a565e0bb44e189f02d8ce69bd23 100644

--- a/chrome/browser/autocomplete/history_quick_provider.cc

+++ b/chrome/browser/autocomplete/history_quick_provider.cc

@@ -90,14 +90,6 @@ void HistoryQuickProvider::Start(const AutocompleteInput& input,

}

-void HistoryQuickProvider::DeleteMatch(const AutocompleteMatch& match) {

- DCHECK(match.deletable);

- DCHECK(match.destination_url.is_valid());

- // Delete the match from the InMemoryURLIndex.

- GetIndex()->DeleteURL(match.destination_url);

- DeleteMatchFromMatches(match);

HistoryQuickProvider::~HistoryQuickProvider() {}

void HistoryQuickProvider::DoAutocomplete() {