SSL Connect Job Waiting

net/socket/ssl_client_socket_openssl.h

Index: net/socket/ssl_client_socket_openssl.h
diff --git a/net/socket/ssl_client_socket_openssl.h b/net/socket/ssl_client_socket_openssl.h
index 5d70c0523fabe0230b2361f7418688f1215fe0df..77287d3c11d9c1e90e3d007bf3a462c0ef9a32db 100644
--- a/net/socket/ssl_client_socket_openssl.h
+++ b/net/socket/ssl_client_socket_openssl.h
@@ -56,6 +56,13 @@ class SSLClientSocketOpenSSL : public SSLClientSocket {
     return ssl_session_cache_shard_;
   }
 
+  // Returns true if there is a cache entry in the ssl session cache
+  // for the given |cache key|.
+  //
+  // |cache_key| consists of an SSLConnectJobs host_and_port name
+  // concatenated with its session cache shard.

[wtc, 2014/06/17 17:44:40]

This comment should be moved to ssl_client_socket.h. In a method of a subclass
that overrides a method of a base class, the comment is usually omitted.

[mshelley1, 2014/06/18 18:53:49]

Done.

+  virtual bool InSessionCache();

[wtc, 2014/06/17 17:44:40]

Move this method down to the "SSLClientSocket implementation" section. Add the
"OVERRIDE" keyword.

[mshelley1, 2014/06/18 18:53:49]

Done.

+
   // SSLClientSocket implementation.
   virtual void GetSSLCertRequestInfo(
       SSLCertRequestInfo* cert_request_info) OVERRIDE;