SSL Connect Job Waiting

net/socket/ssl_client_socket_openssl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SOCKET_SSL_CLIENT_SOCKET_OPENSSL_H_
 #define NET_SOCKET_SSL_CLIENT_SOCKET_OPENSSL_H_
 
 #include <string>
 
 #include "base/compiler_specific.h"
@@ skipping 38 matching lines @@
                          const HostPortPair& host_and_port,
                          const SSLConfig& ssl_config,
                          const SSLClientSocketContext& context);
   virtual ~SSLClientSocketOpenSSL();
 
   const HostPortPair& host_and_port() const { return host_and_port_; }
   const std::string& ssl_session_cache_shard() const {
     return ssl_session_cache_shard_;
   }
 
+  // Returns true if there is a cache entry in the ssl session cache
+  // for the given |cache key|.
+  //
+  // |cache_key| consists of an SSLConnectJobs host_and_port name
+  // concatenated with its session cache shard.

[wtc, 2014/06/17 17:44:40]

This comment should be moved to ssl_client_socket.h. In a method of a subclass
that overrides a method of a base class, the comment is usually omitted.

[mshelley1, 2014/06/18 18:53:49]

Done.

+  virtual bool InSessionCache();

[wtc, 2014/06/17 17:44:40]

Move this method down to the "SSLClientSocket implementation" section. Add the
"OVERRIDE" keyword.

[mshelley1, 2014/06/18 18:53:49]

Done.

+
   // SSLClientSocket implementation.
   virtual void GetSSLCertRequestInfo(
       SSLCertRequestInfo* cert_request_info) OVERRIDE;
   virtual NextProtoStatus GetNextProto(std::string* proto,
                                        std::string* server_protos) OVERRIDE;
   virtual ServerBoundCertService* GetServerBoundCertService() const OVERRIDE;
 
   // SSLSocket implementation.
   virtual int ExportKeyingMaterial(const base::StringPiece& label,
                                    bool has_context,
@@ skipping 172 matching lines @@
   // True if channel ID extension was negotiated.
   bool channel_id_xtn_negotiated_;
   // The request handle for |server_bound_cert_service_|.
   ServerBoundCertService::RequestHandle channel_id_request_handle_;
   BoundNetLog net_log_;
 };
 
 }  // namespace net
 
 #endif  // NET_SOCKET_SSL_CLIENT_SOCKET_OPENSSL_H_