Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1134)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/socket/ssl_session_cache_openssl.h

Issue 328903004: SSL Connect Job Waiting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added a command line flag that enables my changes. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/socket/ssl_client_socket_pool.cc ('K') | « net/socket/ssl_client_socket_pool.cc ('k') | net/socket/ssl_session_cache_openssl.cc » ('j') | net/socket/ssl_session_cache_openssl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_session_cache_openssl.h
diff --git a/net/socket/ssl_session_cache_openssl.h b/net/socket/ssl_session_cache_openssl.h
index bbd9659641df062dc870880f805031006deddb59..3dc7a5d80e6e8f57897efc7b2290ca4878c79dd5 100644
--- a/net/socket/ssl_session_cache_openssl.h
+++ b/net/socket/ssl_session_cache_openssl.h
@@ -113,6 +113,12 @@ class NET_EXPORT SSLSessionCacheOpenSSL {
// Return true iff a cached session was associated with the |ssl| connection.
bool SetSSLSessionWithKey(SSL* ssl, const std::string& cache_key);
+ // Allows an SSLConnectionJob to determine if its intended connection is
+ // in the session cache.
wtc 2014/06/13 22:47:24 Nit: the documentation should ideally not refer to
mshelley1 2014/06/16 19:02:51 Done.
+ //
+ // Return true iff a cached session was associated with the given cache_key.
wtc 2014/06/13 22:47:24 Nit: put code in ||, for example, |cache_key|.
mshelley1 2014/06/16 19:02:51 Done.
+ bool SessionIsInCache(const std::string& cache_key);
wtc 2014/06/13 22:47:24 Nit: Mark this method const: bool SessionIsInCa
mshelley1 2014/06/16 19:02:51 Done.
+
// Indicates that the SSL session associated with |ssl| is "good" - that is,
// that all associated cryptographic parameters that were negotiated,
// including the peer's certificate, were successfully validated. Because
« net/socket/ssl_client_socket_pool.cc ('K') | « net/socket/ssl_client_socket_pool.cc ('k') | net/socket/ssl_session_cache_openssl.cc » ('j') | net/socket/ssl_session_cache_openssl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698