SSL Connect Job Waiting

net/socket/ssl_session_cache_openssl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SOCKET_SSL_SESSION_CACHE_OPENSSL_H
 #define NET_SOCKET_SSL_SESSION_CACHE_OPENSSL_H
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 95 matching lines @@
   // ensure that the value of |cache_key| matches the result of calling the
   // configuration's |key_func| function with the |ssl| as parameter.
   //
   // Every |check_expiration_count| call to either SetSSLSession() or
   // SetSSLSessionWithKey() triggers a check for, and removal of, expired
   // sessions.
   //
   // Return true iff a cached session was associated with the |ssl| connection.
   bool SetSSLSessionWithKey(SSL* ssl, const std::string& cache_key);
 
+  // Allows an SSLConnectionJob to determine if its intended connection is
+  // in the session cache.

[wtc, 2014/06/13 22:47:24]

Nit: the documentation should ideally not refer to the intended user
(SSLConnectJob). I think we can just delete this sentence.

[mshelley1, 2014/06/16 19:02:51]

Done.

+  //
+  // Return true iff a cached session was associated with the given cache_key.

[wtc, 2014/06/13 22:47:24]

Nit: put code in ||, for example, |cache_key|.

[mshelley1, 2014/06/16 19:02:51]

Done.

+  bool SessionIsInCache(const std::string& cache_key);

[wtc, 2014/06/13 22:47:24]

Nit: Mark this method const:

  bool SessionIsInCache(const std::string& cache_key) const;

[mshelley1, 2014/06/16 19:02:51]

Done.

+
   // Indicates that the SSL session associated with |ssl| is "good" - that is,
   // that all associated cryptographic parameters that were negotiated,
   // including the peer's certificate, were successfully validated. Because
   // OpenSSL does not provide an asynchronous certificate verification
   // callback, it's necessary to manually manage the sessions to ensure that
   // only validated sessions are resumed.
   void MarkSSLSessionAsGood(SSL* ssl);
 
   // Flush removes all entries from the cache. This is typically called when
   // the system's certificate store has changed.
   void Flush();
 
   // TODO(digit): Move to client code.
   static const int kDefaultTimeoutSeconds = 60 * 60;
   static const size_t kMaxEntries = 1024;
   static const size_t kMaxExpirationChecks = 256;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(SSLSessionCacheOpenSSL);
 
   SSLSessionCacheOpenSSLImpl* impl_;
 };
 
 }  // namespace net
 
 #endif  // NET_SOCKET_SSL_SESSION_CACHE_OPENSSL_H