Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 328873002: Renames view manager Connect methods to Embed (Closed)

Created:
6 years, 6 months ago by sky
Modified:
6 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Renames view manager Connect methods to Embed Specifically: IViewManagerInit::Connect->EmbedRoot IViewManager::Connect->Embed R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276411

Patch Set 1 #

Patch Set 2 : mispelling #

Messages

Total messages: 8 (0 generated)
sky
6 years, 6 months ago (2014-06-10 21:42:16 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 6 months ago (2014-06-10 21:50:56 UTC) #2
sky
The CQ bit was checked by sky@chromium.org
6 years, 6 months ago (2014-06-10 22:15:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/328873002/20001
6 years, 6 months ago (2014-06-10 22:17:50 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 04:22:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 07:29:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/25721)
6 years, 6 months ago (2014-06-11 07:29:17 UTC) #7
sky
6 years, 6 months ago (2014-06-11 15:40:20 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r276411 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698