mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc - Issue 328873002: Renames view manager Connect methods to Embed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc

Issue 328873002: Renames view manager Connect methods to Embed (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: mispelling Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/examples/demo_launcher/demo_launcher.cc ('k') | mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc

diff --git a/mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc b/mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc

index 555673d28bb36da38c937b3084e5cd798d8a884a..dd65507f6758590fea09ab68b180e9ef7c6af84e 100644

--- a/mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc

+++ b/mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc

@@ -448,8 +448,7 @@ class EmbedTransaction : public ViewManagerTransaction {

virtual void DoCommit() OVERRIDE {

std::vector<Id> ids;

ids.push_back(node_id_);

- service()->Connect(url_, Array<Id>::From(ids),

- ActionCompletedCallback());

+ service()->Embed(url_, Array<Id>::From(ids), ActionCompletedCallback());

}

virtual void DoActionCompleted(bool success) OVERRIDE {

// TODO(beng): recovery?