Ensure SpdySession::StartGoingAway is always called with an error.

Ensure SpdySession::StartGoingAway is always called with an error.

Also add test coverage of SPDY network changes with created streams.

BUG=382553
R=rch@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276495

[Ryan Hamilton, 2014-06-11 17:05:59]

LGTM modulo one small comment.

https://codereview.chromium.org/328823003/diff/20001/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (right):

https://codereview.chromium.org/328823003/diff/20001/net/spdy/spdy_session.cc...
net/spdy/spdy_session.cc:1604: StartGoingAway(0, ERR_ABORTED);
Hm. Handling DCHECKS is verboten in Chrome. (There's a thread about this on
chromium-dev in the last day or so). You could use a DFATAL, however.

[Johnny, 2014-06-11 17:17:21]

https://codereview.chromium.org/328823003/diff/20001/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (right):

https://codereview.chromium.org/328823003/diff/20001/net/spdy/spdy_session.cc...
net/spdy/spdy_session.cc:1604: StartGoingAway(0, ERR_ABORTED);
Removed.

[Johnny, 2014-06-11 17:17:34]

The CQ bit was checked by jgraettinger@chromium.org

[commit-bot: I haz the power, 2014-06-11 17:19:01]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/328823003/40001

[commit-bot: I haz the power, 2014-06-11 20:39:41]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-11 21:00:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 21:00:36]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[Johnny, 2014-06-11 22:10:57]

The CQ bit was checked by jgraettinger@chromium.org

[commit-bot: I haz the power, 2014-06-11 22:14:03]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/328823003/40001

[commit-bot: I haz the power, 2014-06-11 22:46:17]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-11 22:47:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 22:47:58]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[Johnny, 2014-06-11 23:01:37]

Committed patchset #3 manually as r276495 (tree was closed).