net/spdy/spdy_session_pool.cc - Issue 328823003: Ensure SpdySession::StartGoingAway is always called with an error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_session_pool.cc

Issue 328823003: Ensure SpdySession::StartGoingAway is always called with an error. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove extraneous StartGoingAway Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_session_pool.cc

diff --git a/net/spdy/spdy_session_pool.cc b/net/spdy/spdy_session_pool.cc

index d523e10198660129645de75a7b25483bc44150e0..189c9453cadbe7012faaca8112970e032cc19efc 100644

--- a/net/spdy/spdy_session_pool.cc

+++ b/net/spdy/spdy_session_pool.cc

@@ -284,7 +284,7 @@ void SpdySessionPool::OnIPAddressChanged() {

// to a generated TCP reset.

#if defined(OS_ANDROID) || defined(OS_WIN) || defined(OS_IOS)

(*it)->MakeUnavailable();

- (*it)->StartGoingAway(kLastStreamId, OK);

+ (*it)->StartGoingAway(kLastStreamId, ERR_NETWORK_CHANGED);

(*it)->MaybeFinishGoingAway();

#else

(*it)->CloseSessionOnError(ERR_NETWORK_CHANGED,

« no previous file with comments | « net/spdy/spdy_session.cc ('k') | net/spdy/spdy_session_pool_unittest.cc » ('j') | no next file with comments »