Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 328803002: Handle metadata in the magic [^] property of class descriptions correctly. (Closed)

Created:
6 years, 6 months ago by herhut
Modified:
6 years, 6 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, floitsch, kevmoo
Visibility:
Public.

Description

Handle metadata in the magic [^] property of class descriptions correctly. BUG= http://dartbug.com/19173 R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=37256

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart View 1 chunk +1 line, -0 lines 0 comments Download
A + tests/lib/mirrors/metadata_class_mirror_test.dart View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
herhut
6 years, 6 months ago (2014-06-10 17:51:44 UTC) #1
karlklose
LGTM.
6 years, 6 months ago (2014-06-12 08:29:10 UTC) #2
herhut
6 years, 6 months ago (2014-06-12 08:34:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37256 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698