Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 328693003: Revert "Support external startup data in V8." (Closed)

Created:
6 years, 6 months ago by Michael Achenbach
Modified:
6 years, 6 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert "Support external startup data in V8." This reverts commit r21696 for breaking chromium windows compilation in the chromium cq. Conflicts: src/d8.cc BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21740

Patch Set 1 #

Patch Set 2 : Fix brace. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -1045 lines) Patch
M BUILD.gn View 4 chunks +1 line, -9 lines 0 comments Download
M build/features.gypi View 2 chunks +3 lines, -8 lines 0 comments Download
M include/v8.h View 1 chunk +0 lines, -18 lines 0 comments Download
M src/api.cc View 2 chunks +2 lines, -18 lines 0 comments Download
M src/d8.h View 2 chunks +1 line, -5 lines 0 comments Download
M src/d8.cc View 1 2 chunks +0 lines, -64 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mksnapshot.cc View 5 chunks +12 lines, -59 lines 0 comments Download
M src/natives.h View 2 chunks +0 lines, -9 lines 0 comments Download
D src/natives-external.cc View 1 chunk +0 lines, -190 lines 0 comments Download
M src/serialize.h View 4 chunks +75 lines, -3 lines 0 comments Download
M src/serialize.cc View 3 chunks +21 lines, -1 line 0 comments Download
M src/snapshot.h View 2 chunks +10 lines, -7 lines 0 comments Download
M src/snapshot-common.cc View 3 chunks +52 lines, -13 lines 0 comments Download
D src/snapshot-external.cc View 1 chunk +0 lines, -140 lines 0 comments Download
D src/snapshot-source-sink.h View 1 chunk +0 lines, -88 lines 0 comments Download
D src/snapshot-source-sink.cc View 1 chunk +0 lines, -95 lines 0 comments Download
M test/cctest/test-serialize.cc View 3 chunks +39 lines, -56 lines 0 comments Download
D tools/concatenate-files.py View 1 chunk +0 lines, -75 lines 0 comments Download
M tools/gyp/v8.gyp View 10 chunks +7 lines, -132 lines 0 comments Download
M tools/js2c.py View 8 chunks +10 lines, -52 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL. This blocks the roll. Breaks window, e.g. here: http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/24490/steps/compile%20%28with%20patch%2C%20lkcr%2C%20clobber%29/logs/stdio
6 years, 6 months ago (2014-06-10 10:09:13 UTC) #1
Michael Starzinger
LGTM (rubber-stamped).
6 years, 6 months ago (2014-06-10 10:13:06 UTC) #2
Michael Achenbach
6 years, 6 months ago (2014-06-10 10:51:48 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r21740 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698