Get rid of scheduleSVGFilterLayerUpdateHack call for plugins.

Get rid of scheduleSVGFilterLayerUpdateHack call for plugins.

We need to store a bit on the RenderStyle as to whether it needs
to be accelerated due to the plugin having a layer so that when
we recalc style on it, we actually get a different style and
call setStyle. This is needed so styleChanged gets called
and we get a NormalLayer RenderLayer.

This is better than the current hack because we'd like it to
be an invariant that setStyle is only called when the style
actually changed.

Revert "Psuedo revert "s/scheduleLayerUpdate/setNeedsCompositingUpdate in setWebLayer.""

This reverts commit 2c54e3cf4c74a20c2319bc3bae26904fbb462330.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175914

[esprehn, 2014-06-10 02:19:10]

https://codereview.chromium.org/328553004/diff/1/Source/core/css/resolver/Sty...
File Source/core/css/resolver/StyleAdjuster.cpp (right):

https://codereview.chromium.org/328553004/diff/1/Source/core/css/resolver/Sty...
Source/core/css/resolver/StyleAdjuster.cpp:376: if
(isHTMLPlugInElement(element))
Can you add braces and an early return? I know it's not really needed, but it
means as this function grows people don't need to go back and edit your lines.

https://codereview.chromium.org/328553004/diff/1/Source/core/html/HTMLPlugInE...
File Source/core/html/HTMLPlugInElement.cpp (right):

https://codereview.chromium.org/328553004/diff/1/Source/core/html/HTMLPlugInE...
Source/core/html/HTMLPlugInElement.cpp:176: bool
HTMLPlugInElement::shouldAccelerate()
const ?

https://codereview.chromium.org/328553004/diff/1/Source/web/WebPluginContaine...
File Source/web/WebPluginContainerImpl.cpp (right):

https://codereview.chromium.org/328553004/diff/1/Source/web/WebPluginContaine...
Source/web/WebPluginContainerImpl.cpp:295:
m_element->setNeedsStyleRecalc(LocalStyleChange);
Can you add a comment why you need to trigger this recalc style?

[ojan, 2014-06-10 18:33:31]

All done.

[commit-bot: I haz the power, 2014-06-10 18:34:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ojan@chromium.org/328553004/20001

[commit-bot: I haz the power, 2014-06-10 18:34:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-10 18:34:27]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[esprehn, 2014-06-10 18:35:49]

lgtm, hopefully we can get rid of that setNeedsStyleRecalc someday too, but this
is fine for now.

[esprehn, 2014-06-10 18:36:03]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-06-10 18:36:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ojan@chromium.org/328553004/20001

[commit-bot: I haz the power, 2014-06-10 19:43:55]

Change committed as 175914

[ojan, 2014-06-10 20:30:50]

On 2014/06/10 at 18:35:49, esprehn wrote:
> lgtm, hopefully we can get rid of that setNeedsStyleRecalc someday too, but
this is fine for now.

Oh noes. I didn't noticed that you CQ'ed. I realized that we don't need it and
uploaded a new patch that just udpates the self painting layer bit. I'll upload
a new patch that fixes this.

[ojan, 2014-06-10 20:38:39]

https://codereview.chromium.org/322193002