Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Issue 322193002: Don't do a style recalc when updating the composited layer of a plugin. (Closed)

Created:
6 years, 6 months ago by ojan
Modified:
6 years, 6 months ago
Reviewers:
esprehn
CC:
blink-reviews
Visibility:
Public.

Description

Don't do a style recalc when updating the composited layer of a plugin. Since the renderer for the plugin always gets either a NormalLayer or a ForcedLayer, it will have a RenderLayer whether it's composited or not, so all we have to do is update it's self painting layer bit. This is a followup to https://codereview.chromium.org/328553004. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175942

Patch Set 1 #

Patch Set 2 : fix assert #

Total comments: 1

Patch Set 3 : rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M Source/web/WebPluginContainerImpl.cpp View 1 2 2 chunks +17 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ojan
6 years, 6 months ago (2014-06-10 20:38:31 UTC) #1
esprehn
lgtm https://codereview.chromium.org/322193002/diff/20001/Source/web/WebPluginContainerImpl.cpp File Source/web/WebPluginContainerImpl.cpp (right): https://codereview.chromium.org/322193002/diff/20001/Source/web/WebPluginContainerImpl.cpp#newcode297 Source/web/WebPluginContainerImpl.cpp:297: // If anyone of the layers is null ...
6 years, 6 months ago (2014-06-10 21:14:37 UTC) #2
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 6 months ago (2014-06-11 02:14:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/322193002/40001
6 years, 6 months ago (2014-06-11 02:14:34 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-11 03:37:30 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 04:47:49 UTC) #6
Message was sent while issue was closed.
Change committed as 175942

Powered by Google App Engine
This is Rietveld 408576698