Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 328423002: Reactivate building browser_tests.exe for Windows official builds. (Closed)

Created:
6 years, 6 months ago by anandc
Modified:
6 years, 6 months ago
Reviewers:
Michael Moss, mmoss
CC:
chromium-reviews
Visibility:
Public.

Description

Now that the fix to the build-warning seen earlier, https://codereview.chromium.org/333443002 has landed, reactivate building browser_tests.exe for official Windows builds. BUG=379986 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276835

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
anandc
Hi Michael, PTAL. I've also kicked off an official Chrome build on my Windows desktop, ...
6 years, 6 months ago (2014-06-12 17:43:44 UTC) #1
Michael Moss
lgtm
6 years, 6 months ago (2014-06-12 18:06:01 UTC) #2
anandc
The CQ bit was checked by anandc@chromium.org
6 years, 6 months ago (2014-06-12 18:17:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anandc@chromium.org/328423002/1
6 years, 6 months ago (2014-06-12 18:21:13 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 22:45:55 UTC) #5
Message was sent while issue was closed.
Change committed as 276835

Powered by Google App Engine
This is Rietveld 408576698