|
|
Created:
6 years, 6 months ago by anandc Modified:
6 years, 6 months ago Reviewers:
gab CC:
chromium-reviews Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionAdd an #else to #ifdef OFFICIAL_BUILD
BUG=383430
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276583
Patch Set 1 #
Messages
Total messages: 15 (0 generated)
This http://src.chromium.org/viewvc/chrome?revision=276388&view=revision, to turn on building of browser_tests.exe for Official Windows builds was rolled-back, because there was a warning related to unreachable code in pref_hash_browsertest.cc. See log file here: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/bu... This CL attempts to fix that warning so that we may then re-enable browser_tests.exe for official Windows builds. Thanks.
lgtm
The CQ bit was checked by anandc@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anandc@chromium.org/333443002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...) mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...) win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...) win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...) mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
The CQ bit was checked by anandc@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anandc@chromium.org/333443002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...) mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...) win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...) win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...) mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...) win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...) win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
The CQ bit was checked by anandc@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anandc@chromium.org/333443002/1
Message was sent while issue was closed.
Change committed as 276583 |