Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 333443002: Fix warning seen for Official Chrome Windows builds. (Closed)

Created:
6 years, 6 months ago by anandc
Modified:
6 years, 6 months ago
Reviewers:
gab
CC:
chromium-reviews
Visibility:
Public.

Description

Add an #else to #ifdef OFFICIAL_BUILD BUG=383430 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276583

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome/browser/prefs/pref_hash_browsertest.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
anandc
This http://src.chromium.org/viewvc/chrome?revision=276388&view=revision, to turn on building of browser_tests.exe for Official Windows builds was rolled-back, because ...
6 years, 6 months ago (2014-06-11 17:33:50 UTC) #1
gab
lgtm
6 years, 6 months ago (2014-06-11 18:25:35 UTC) #2
anandc
The CQ bit was checked by anandc@chromium.org
6 years, 6 months ago (2014-06-11 18:32:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anandc@chromium.org/333443002/1
6 years, 6 months ago (2014-06-11 18:36:15 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 21:18:20 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:25:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/21863) mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/37998)
6 years, 6 months ago (2014-06-11 21:25:11 UTC) #7
anandc
The CQ bit was checked by anandc@chromium.org
6 years, 6 months ago (2014-06-11 21:48:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anandc@chromium.org/333443002/1
6 years, 6 months ago (2014-06-11 21:50:34 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device_ninja on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 22:53:45 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 22:55:46 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/builds/21930) mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/38117) win_chromium_rel ...
6 years, 6 months ago (2014-06-11 22:55:47 UTC) #12
anandc
The CQ bit was checked by anandc@chromium.org
6 years, 6 months ago (2014-06-12 01:09:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anandc@chromium.org/333443002/1
6 years, 6 months ago (2014-06-12 01:11:52 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 08:23:44 UTC) #15
Message was sent while issue was closed.
Change committed as 276583

Powered by Google App Engine
This is Rietveld 408576698