Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 328383002: Merge 276305 "cc: Don't cleanup the pending twin's low res tiling." (Closed)

Created:
6 years, 6 months ago by danakj
Modified:
6 years, 6 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Merge 276305 "cc: Don't cleanup the pending twin's low res tiling." > cc: Don't cleanup the pending twin's low res tiling. > > After drawing, we cull unused tilings on the active tree. If we cull > the tiling which is the low res tiling on the pending tree, and then > later do a pinch such that the active tree wants a tiling of that scale > again, it would create the tiling which is already on the pending tree > and cause a bad state. > > Adds a unit test that was hitting the CHECK() in PictureLayerImpl when > it changed the scale of the active layer to 1.f to match the pending > layer after drawing. Now it verifies that the active layer keeps the > pending low res tiling. > > R=enne > BUG=358350 > > Review URL: https://codereview.chromium.org/323193002 TBR=danakj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276695

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -8 lines) Patch
M cc/layers/picture_layer_impl.cc View 3 chunks +12 lines, -2 lines 0 comments Download
M cc/resources/picture_layer_tiling_set.cc View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
danakj
6 years, 6 months ago (2014-06-12 16:04:28 UTC) #1
danakj
6 years, 6 months ago (2014-06-12 16:05:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r276695 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698