Issue 323193002: cc: Don't cleanup the pending twin's low res tiling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 323193002: cc: Don't cleanup the pending twin's low res tiling. (Closed)

Created:
6 years, 6 months ago by danakj

Modified:
6 years, 6 months ago

Reviewers:
enne (OOO)

CC:
cc-bugs_chromium.org, chromium-reviews, piman, vmpstr

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cc: Don't cleanup the pending twin's low res tiling. After drawing, we cull unused tilings on the active tree. If we cull the tiling which is the low res tiling on the pending tree, and then later do a pinch such that the active tree wants a tiling of that scale again, it would create the tiling which is already on the pending tree and cause a bad state. Adds a unit test that was hitting the CHECK() in PictureLayerImpl when it changed the scale of the active layer to 1.f to match the pending layer after drawing. Now it verifies that the active layer keeps the pending low res tiling. R=enne BUG=358350 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276305

Patch Set 1 #

Patch Set 2 : scale-collision: . #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -9 lines)			Patch
M	cc/layers/picture_layer_impl.cc	View		3 chunks	+12 lines, -3 lines	0 comments	Download
M	cc/layers/picture_layer_impl_unittest.cc	View		1 chunk	+80 lines, -0 lines	0 comments	Download
M	cc/resources/picture_layer_tiling_set.cc	View	1	1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/323193002/20001

6 years, 6 months ago (2014-06-10 23:14:54 UTC) #3

Message was sent while issue was closed.

Change committed as 276305

Expand Messages | Collapse Messages