Issue 328353002: Add non-miss slow path to LoadIC_Normal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 328353002: Add non-miss slow path to LoadIC_Normal. (Closed)

Created:
6 years, 6 months ago by Jakob Kummerow

Modified:
6 years, 6 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Add non-miss slow path to LoadIC_Normal. This avoids endless IC patching cycles between "normal" and "nonexistent" handlers when objects having and not having the property are seen alternatingly R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21816

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -12 lines)			Patch
M	src/arm/ic-arm.cc	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/arm64/ic-arm64.cc	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/ia32/ic-ia32.cc	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/mips/ic-mips.cc	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/x64/ic-x64.cc	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/x87/ic-x87.cc	View	1 chunk	+6 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Yang

On 2014/06/12 15:24:16, Jakob wrote: > PTAL. LGTM. Maybe a test case, maybe not.

6 years, 6 months ago (2014-06-12 15:26:41 UTC) #2

Jakob Kummerow

On 2014/06/12 15:26:41, Yang wrote: > Maybe a test case, maybe not. Testcase is in ...

6 years, 6 months ago (2014-06-12 16:36:54 UTC) #3

Jakob Kummerow

6 years, 6 months ago (2014-06-12 16:39:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r21816 (presubmit successful).