Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Side by Side Diff: src/ia32/ic-ia32.cc

Issue 328353002: Add non-miss slow path to LoadIC_Normal. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm64/ic-arm64.cc ('k') | src/mips/ic-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/ic-inl.h" 10 #include "src/ic-inl.h"
(...skipping 929 matching lines...) Expand 10 before | Expand all | Expand 10 after
940 GenerateMiss(masm); 940 GenerateMiss(masm);
941 } 941 }
942 942
943 943
944 void LoadIC::GenerateNormal(MacroAssembler* masm) { 944 void LoadIC::GenerateNormal(MacroAssembler* masm) {
945 // ----------- S t a t e ------------- 945 // ----------- S t a t e -------------
946 // -- ecx : name 946 // -- ecx : name
947 // -- edx : receiver 947 // -- edx : receiver
948 // -- esp[0] : return address 948 // -- esp[0] : return address
949 // ----------------------------------- 949 // -----------------------------------
950 Label miss; 950 Label miss, slow;
951 951
952 GenerateNameDictionaryReceiverCheck(masm, edx, eax, ebx, &miss); 952 GenerateNameDictionaryReceiverCheck(masm, edx, eax, ebx, &miss);
953 953
954 // eax: elements 954 // eax: elements
955 // Search the dictionary placing the result in eax. 955 // Search the dictionary placing the result in eax.
956 GenerateDictionaryLoad(masm, &miss, eax, ecx, edi, ebx, eax); 956 GenerateDictionaryLoad(masm, &slow, eax, ecx, edi, ebx, eax);
957 __ ret(0); 957 __ ret(0);
958 958
959 // Dictionary load failed, go slow (but don't miss).
960 __ bind(&slow);
961 GenerateRuntimeGetProperty(masm);
962
959 // Cache miss: Jump to runtime. 963 // Cache miss: Jump to runtime.
960 __ bind(&miss); 964 __ bind(&miss);
961 GenerateMiss(masm); 965 GenerateMiss(masm);
962 } 966 }
963 967
964 968
965 void LoadIC::GenerateMiss(MacroAssembler* masm) { 969 void LoadIC::GenerateMiss(MacroAssembler* masm) {
966 // ----------- S t a t e ------------- 970 // ----------- S t a t e -------------
967 // -- ecx : name 971 // -- ecx : name
968 // -- edx : receiver 972 // -- edx : receiver
(...skipping 308 matching lines...) Expand 10 before | Expand all | Expand 10 after
1277 Condition cc = (check == ENABLE_INLINED_SMI_CHECK) 1281 Condition cc = (check == ENABLE_INLINED_SMI_CHECK)
1278 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero) 1282 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero)
1279 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry); 1283 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry);
1280 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 1284 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
1281 } 1285 }
1282 1286
1283 1287
1284 } } // namespace v8::internal 1288 } } // namespace v8::internal
1285 1289
1286 #endif // V8_TARGET_ARCH_IA32 1290 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm64/ic-arm64.cc ('k') | src/mips/ic-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698