Issue 328133002: Oilpan: move Page's PointerLockController object to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 328133002: Oilpan: move Page's PointerLockController object to the heap. (Closed)

Created:
6 years, 6 months ago by sof

Modified:
6 years, 6 months ago

Reviewers:
oilpan-reviews, haraken, Mads Ager (chromium)

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Oilpan: move Page's PointerLockController object to the heap. Move this Page-owned controller object to the heap, allowing a pair of Persistent<> references to be removed in the process. R=ager@chromium.org BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175957

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -9 lines)			Patch
M	Source/core/page/Page.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/page/Page.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/page/PointerLockController.h	View	2 chunks	+8 lines, -6 lines	0 comments	Download
M	Source/core/page/PointerLockController.cpp	View	2 chunks	+9 lines, -2 lines	0 comments	Download

Total messages: 7 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/328133002/1

6 years, 6 months ago (2014-06-11 11:25:05 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...

6 years, 6 months ago (2014-06-11 12:19:46 UTC) #6

Message was sent while issue was closed.

Change committed as 175957