Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: Source/core/page/PointerLockController.h

Issue 328133002: Oilpan: move Page's PointerLockController object to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/Page.cpp ('k') | Source/core/page/PointerLockController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/PointerLockController.h
diff --git a/Source/core/page/PointerLockController.h b/Source/core/page/PointerLockController.h
index f2eaef22fd2c832374ed2a510e670ade7db129c4..dd24d638f2919dca0f601da7f2287357829ae22b 100644
--- a/Source/core/page/PointerLockController.h
+++ b/Source/core/page/PointerLockController.h
@@ -37,11 +37,11 @@ class Page;
class PlatformMouseEvent;
class VoidCallback;
-class PointerLockController {
+class PointerLockController FINAL : public NoBaseWillBeGarbageCollected<PointerLockController> {
WTF_MAKE_NONCOPYABLE(PointerLockController);
- WTF_MAKE_FAST_ALLOCATED;
+ WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED;
public:
- static PassOwnPtr<PointerLockController> create(Page*);
+ static PassOwnPtrWillBeRawPtr<PointerLockController> create(Page*);
void requestPointerLock(Element* target);
void requestPointerUnlock();
@@ -55,16 +55,18 @@ public:
void didLosePointerLock();
void dispatchLockedMouseEvent(const PlatformMouseEvent&, const AtomicString& eventType);
+ void trace(Visitor*);
+
private:
explicit PointerLockController(Page*);
void clearElement();
void enqueueEvent(const AtomicString& type, Element*);
void enqueueEvent(const AtomicString& type, Document*);
- Page* m_page;
+ RawPtrWillBeMember<Page> m_page;
bool m_lockPending;
- RefPtrWillBePersistent<Element> m_element;
- RefPtrWillBePersistent<Document> m_documentOfRemovedElementWhileWaitingForUnlock;
+ RefPtrWillBeMember<Element> m_element;
+ RefPtrWillBeMember<Document> m_documentOfRemovedElementWhileWaitingForUnlock;
};
} // namespace WebCore
« no previous file with comments | « Source/core/page/Page.cpp ('k') | Source/core/page/PointerLockController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698