Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 327953002: Make MessagingBindings use ScriptContextSet::ForEach (Closed)

Created:
6 years, 6 months ago by not at google - send to devlin
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Make MessagingBindings use ScriptContextSet::ForEach. This is a long-standing TODO and should address the dead isolate issue in bug 382179. BUG=382179 R=rockot@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276529

Patch Set 1 #

Patch Set 2 : other methods #

Patch Set 3 : ForEach shortcuts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -190 lines) Patch
M extensions/renderer/dispatcher.cc View 1 2 4 chunks +4 lines, -8 lines 0 comments Download
M extensions/renderer/extension_helper.cc View 1 1 chunk +10 lines, -18 lines 0 comments Download
M extensions/renderer/messaging_bindings.h View 1 3 chunks +9 lines, -8 lines 0 comments Download
M extensions/renderer/messaging_bindings.cc View 1 2 4 chunks +142 lines, -148 lines 0 comments Download
M extensions/renderer/resources/messaging.js View 2 chunks +5 lines, -2 lines 0 comments Download
M extensions/renderer/script_context.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/renderer/script_context.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/renderer/script_context_set.h View 1 2 1 chunk +13 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
not at google - send to devlin
7 files changed, 177 insertions(+), 186 deletions(-)
6 years, 6 months ago (2014-06-10 22:57:24 UTC) #1
not at google - send to devlin
it's a pretty mechanical change. process is: - cut contents of for..loops - create new ...
6 years, 6 months ago (2014-06-10 22:58:39 UTC) #2
Ken Rockot(use gerrit already)
LGTM. As a nit, it would be cool if there were a version of ForEach ...
6 years, 6 months ago (2014-06-11 14:19:00 UTC) #3
not at google - send to devlin
Done. I did the same for the NULL RenderView argument.
6 years, 6 months ago (2014-06-11 15:19:44 UTC) #4
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 6 months ago (2014-06-11 15:20:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/327953002/40001
6 years, 6 months ago (2014-06-11 15:22:28 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 21:00:04 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:14:51 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19584)
6 years, 6 months ago (2014-06-11 21:14:52 UTC) #9
not at google - send to devlin
The CQ bit was checked by kalman@chromium.org
6 years, 6 months ago (2014-06-12 04:04:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/327953002/40001
6 years, 6 months ago (2014-06-12 04:06:02 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 04:12:56 UTC) #12
Message was sent while issue was closed.
Change committed as 276529

Powered by Google App Engine
This is Rietveld 408576698