Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: extensions/renderer/script_context.h

Issue 327953002: Make MessagingBindings use ScriptContextSet::ForEach (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ForEach shortcuts Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/resources/messaging.js ('k') | extensions/renderer/script_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/script_context.h
diff --git a/extensions/renderer/script_context.h b/extensions/renderer/script_context.h
index d5f1ae104487c1bf0ce6ed1e582f93f633aa12a0..26002ec8eea761218c8da745b4fbbb0f005d2b01 100644
--- a/extensions/renderer/script_context.h
+++ b/extensions/renderer/script_context.h
@@ -45,7 +45,7 @@ class ScriptContext : public RequestSender::Source {
bool is_valid() const { return !v8_context_.IsEmpty(); }
v8::Handle<v8::Context> v8_context() const {
- return v8_context_.NewHandle(v8::Isolate::GetCurrent());
+ return v8_context_.NewHandle(isolate());
}
const Extension* extension() const { return extension_.get(); }
@@ -66,7 +66,7 @@ class ScriptContext : public RequestSender::Source {
// Returns the ID of the extension associated with this context, or empty
// string if there is no such extension.
- std::string GetExtensionID() const;
+ const std::string& GetExtensionID() const;
// Returns the RenderView associated with this context. Can return NULL if the
// context is in the process of being destroyed.
« no previous file with comments | « extensions/renderer/resources/messaging.js ('k') | extensions/renderer/script_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698