Issue 327803005: Update the default GYP flags for sanitizer tools.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 327803005: Update the default GYP flags for sanitizer tools. (Closed)

Created:
6 years, 6 months ago by earthdok

Modified:
6 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Update the default GYP flags for sanitizer tools. - use_allocator=none is the default for all tools which replace the allocator, - for MSan, use_custom_libcxx=1 and v8_target_arch=arm64 are the default. BUG=302040 R=glider@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277404

Patch Set 1 #

Total comments: 1

Patch Set 2 : update comment #

Patch Set 3 : update comments #

Created: 6 years, 6 months ago

		Unified diffs	Side-by-side diffs	Stats (+9 lines, -6 lines)
	M	build/common.gypi	View	2 chunks	+9 lines, -6 lines	0 comments

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

LGTM https://codereview.chromium.org/327803005/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/327803005/diff/1/build/common.gypi#newcode2051 build/common.gypi:2051: # that allows the tool to see the ...

6 years, 6 months ago (2014-06-16 10:40:44 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/327803005/40001

6 years, 6 months ago (2014-06-16 11:13:21 UTC) #5

Message was sent while issue was closed.

Change committed as 277404

Expand Messages | Collapse Messages