Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: build/common.gypi

Issue 327803005: Update the default GYP flags for sanitizer tools. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index dd091ebe7674b879f7b3a2c4cd665ddc051be78e..fc4bbc7afc40bdb78578f007daa4d658b147d006 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -2042,7 +2042,7 @@
],
}],
- ['asan==1', {
+ ['asan==1 or msan==1 or lsan==1 or tsan==1', {
'clang%': 1,
'use_allocator%': 'none',
}],
@@ -2054,15 +2054,18 @@
# runtime is fully adopted. See http://crbug.com/242503.
'mac_strip_release': 0,
}],
- ['lsan==1', {
- 'clang%': 1,
- }],
['tsan==1', {
- 'clang%': 1,
'use_custom_libcxx%': 1,
}],
['msan==1', {
- 'clang%': 1,
+ # Use a just-built, MSan-instrumented libc++ instead of the system-wide
+ # libstdc++. This is required to avoid false positive reports whenever
+ # the C++ standard library is used.
+ 'use_custom_libcxx%': 1,
+ # Running the V8-generated code on an ARM simulator is a powerful hack
+ # that allows the tool to see the memory accesses from JITted code.
+ # Without this flag, JS code causes false positive reports from MSan.
+ 'v8_target_arch': 'arm64',
}],
['OS=="linux" and clang_type_profiler==1', {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698