Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3536)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 327793005: Change google_util::AppendGoogleLocaleParam to take in the application locale (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nits Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index ccd4e47f98af8e23159118778e13eec726d57d78..874f9a6a2a6795a52270cd2131019a9185925e3c 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -424,15 +424,21 @@ void ExtensionSettingsHandler::GetLocalizedValues(
l10n_util::GetStringUTF16(IDS_EXTENSIONS_DEVELOPER_MODE_LINK));
source->AddString("extensionSettingsNoExtensions",
l10n_util::GetStringUTF16(IDS_EXTENSIONS_NONE_INSTALLED));
- source->AddString("extensionSettingsSuggestGallery",
- l10n_util::GetStringFUTF16(IDS_EXTENSIONS_NONE_INSTALLED_SUGGEST_GALLERY,
- base::ASCIIToUTF16(google_util::AppendGoogleLocaleParam(
- GURL(extension_urls::GetExtensionGalleryURL())).spec())));
+ source->AddString(
+ "extensionSettingsSuggestGallery",
+ l10n_util::GetStringFUTF16(
+ IDS_EXTENSIONS_NONE_INSTALLED_SUGGEST_GALLERY,
+ base::ASCIIToUTF16(
+ google_util::AppendGoogleLocaleParam(
+ GURL(extension_urls::GetExtensionGalleryURL()),
+ g_browser_process->GetApplicationLocale()).spec())));
source->AddString("extensionSettingsGetMoreExtensions",
l10n_util::GetStringUTF16(IDS_GET_MORE_EXTENSIONS));
source->AddString("extensionSettingsGetMoreExtensionsUrl",
- base::ASCIIToUTF16(google_util::AppendGoogleLocaleParam(
- GURL(extension_urls::GetExtensionGalleryURL())).spec()));
+ base::ASCIIToUTF16(
+ google_util::AppendGoogleLocaleParam(
+ GURL(extension_urls::GetExtensionGalleryURL()),
+ g_browser_process->GetApplicationLocale()).spec()));
source->AddString("extensionSettingsExtensionId",
l10n_util::GetStringUTF16(IDS_EXTENSIONS_ID));
source->AddString("extensionSettingsExtensionPath",
@@ -491,11 +497,15 @@ void ExtensionSettingsHandler::GetLocalizedValues(
source->AddString("extensionSettingsLearnMore",
l10n_util::GetStringUTF16(IDS_LEARN_MORE));
source->AddString("extensionSettingsCorruptInstallHelpUrl",
- base::ASCIIToUTF16(google_util::AppendGoogleLocaleParam(
- GURL(chrome::kCorruptExtensionURL)).spec()));
+ base::ASCIIToUTF16(
+ google_util::AppendGoogleLocaleParam(
+ GURL(chrome::kCorruptExtensionURL),
+ g_browser_process->GetApplicationLocale()).spec()));
source->AddString("extensionSettingsSuspiciousInstallHelpUrl",
- base::ASCIIToUTF16(google_util::AppendGoogleLocaleParam(
- GURL(chrome::kRemoveNonCWSExtensionURL)).spec()));
+ base::ASCIIToUTF16(
+ google_util::AppendGoogleLocaleParam(
+ GURL(chrome::kRemoveNonCWSExtensionURL),
+ g_browser_process->GetApplicationLocale()).spec()));
source->AddString("extensionSettingsShowButton",
l10n_util::GetStringUTF16(IDS_EXTENSIONS_SHOW_BUTTON));
source->AddString("extensionSettingsLoadUnpackedButton",
@@ -510,9 +520,11 @@ void ExtensionSettingsHandler::GetLocalizedValues(
"extensionSettingsAppsDevToolsPromoHTML",
l10n_util::GetStringFUTF16(
IDS_EXTENSIONS_APPS_DEV_TOOLS_PROMO_HTML,
- base::ASCIIToUTF16(google_util::AppendGoogleLocaleParam(
- GURL(extension_urls::GetWebstoreItemDetailURLPrefix() +
- kAppsDeveloperToolsExtensionId)).spec())));
+ base::ASCIIToUTF16(
+ google_util::AppendGoogleLocaleParam(
+ GURL(extension_urls::GetWebstoreItemDetailURLPrefix() +
+ kAppsDeveloperToolsExtensionId),
+ g_browser_process->GetApplicationLocale()).spec())));
source->AddString(
"extensionSettingsAppDevToolsPromoClose",
l10n_util::GetStringUTF16(IDS_CLOSE));

Powered by Google App Engine
This is Rietveld 408576698