Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 327793005: Change google_util::AppendGoogleLocaleParam to take in the application locale (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nits Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h" 5 #include "chrome/browser/ui/webui/extensions/extension_settings_handler.h"
6 6
7 #include "apps/app_load_service.h" 7 #include "apps/app_load_service.h"
8 #include "apps/app_restore_service.h" 8 #include "apps/app_restore_service.h"
9 #include "apps/app_window.h" 9 #include "apps/app_window.h"
10 #include "apps/app_window_registry.h" 10 #include "apps/app_window_registry.h"
(...skipping 406 matching lines...) Expand 10 before | Expand all | Expand 10 after
417 417
418 void ExtensionSettingsHandler::GetLocalizedValues( 418 void ExtensionSettingsHandler::GetLocalizedValues(
419 content::WebUIDataSource* source) { 419 content::WebUIDataSource* source) {
420 source->AddString("extensionSettings", 420 source->AddString("extensionSettings",
421 l10n_util::GetStringUTF16(IDS_MANAGE_EXTENSIONS_SETTING_WINDOWS_TITLE)); 421 l10n_util::GetStringUTF16(IDS_MANAGE_EXTENSIONS_SETTING_WINDOWS_TITLE));
422 422
423 source->AddString("extensionSettingsDeveloperMode", 423 source->AddString("extensionSettingsDeveloperMode",
424 l10n_util::GetStringUTF16(IDS_EXTENSIONS_DEVELOPER_MODE_LINK)); 424 l10n_util::GetStringUTF16(IDS_EXTENSIONS_DEVELOPER_MODE_LINK));
425 source->AddString("extensionSettingsNoExtensions", 425 source->AddString("extensionSettingsNoExtensions",
426 l10n_util::GetStringUTF16(IDS_EXTENSIONS_NONE_INSTALLED)); 426 l10n_util::GetStringUTF16(IDS_EXTENSIONS_NONE_INSTALLED));
427 source->AddString("extensionSettingsSuggestGallery", 427 source->AddString(
428 l10n_util::GetStringFUTF16(IDS_EXTENSIONS_NONE_INSTALLED_SUGGEST_GALLERY, 428 "extensionSettingsSuggestGallery",
429 base::ASCIIToUTF16(google_util::AppendGoogleLocaleParam( 429 l10n_util::GetStringFUTF16(
430 GURL(extension_urls::GetExtensionGalleryURL())).spec()))); 430 IDS_EXTENSIONS_NONE_INSTALLED_SUGGEST_GALLERY,
431 base::ASCIIToUTF16(
432 google_util::AppendGoogleLocaleParam(
433 GURL(extension_urls::GetExtensionGalleryURL()),
434 g_browser_process->GetApplicationLocale()).spec())));
431 source->AddString("extensionSettingsGetMoreExtensions", 435 source->AddString("extensionSettingsGetMoreExtensions",
432 l10n_util::GetStringUTF16(IDS_GET_MORE_EXTENSIONS)); 436 l10n_util::GetStringUTF16(IDS_GET_MORE_EXTENSIONS));
433 source->AddString("extensionSettingsGetMoreExtensionsUrl", 437 source->AddString("extensionSettingsGetMoreExtensionsUrl",
434 base::ASCIIToUTF16(google_util::AppendGoogleLocaleParam( 438 base::ASCIIToUTF16(
435 GURL(extension_urls::GetExtensionGalleryURL())).spec())); 439 google_util::AppendGoogleLocaleParam(
440 GURL(extension_urls::GetExtensionGalleryURL()),
441 g_browser_process->GetApplicationLocale()).spec()));
436 source->AddString("extensionSettingsExtensionId", 442 source->AddString("extensionSettingsExtensionId",
437 l10n_util::GetStringUTF16(IDS_EXTENSIONS_ID)); 443 l10n_util::GetStringUTF16(IDS_EXTENSIONS_ID));
438 source->AddString("extensionSettingsExtensionPath", 444 source->AddString("extensionSettingsExtensionPath",
439 l10n_util::GetStringUTF16(IDS_EXTENSIONS_PATH)); 445 l10n_util::GetStringUTF16(IDS_EXTENSIONS_PATH));
440 source->AddString("extensionSettingsInspectViews", 446 source->AddString("extensionSettingsInspectViews",
441 l10n_util::GetStringUTF16(IDS_EXTENSIONS_INSPECT_VIEWS)); 447 l10n_util::GetStringUTF16(IDS_EXTENSIONS_INSPECT_VIEWS));
442 source->AddString("extensionSettingsInstallWarnings", 448 source->AddString("extensionSettingsInstallWarnings",
443 l10n_util::GetStringUTF16(IDS_EXTENSIONS_INSTALL_WARNINGS)); 449 l10n_util::GetStringUTF16(IDS_EXTENSIONS_INSTALL_WARNINGS));
444 source->AddString("viewIncognito", 450 source->AddString("viewIncognito",
445 l10n_util::GetStringUTF16(IDS_EXTENSIONS_VIEW_INCOGNITO)); 451 l10n_util::GetStringUTF16(IDS_EXTENSIONS_VIEW_INCOGNITO));
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
484 source->AddString("extensionSettingsCorruptInstall", 490 source->AddString("extensionSettingsCorruptInstall",
485 l10n_util::GetStringUTF16( 491 l10n_util::GetStringUTF16(
486 IDS_EXTENSIONS_CORRUPTED_EXTENSION)); 492 IDS_EXTENSIONS_CORRUPTED_EXTENSION));
487 source->AddString("extensionSettingsSuspiciousInstall", 493 source->AddString("extensionSettingsSuspiciousInstall",
488 l10n_util::GetStringFUTF16( 494 l10n_util::GetStringFUTF16(
489 IDS_EXTENSIONS_ADDED_WITHOUT_KNOWLEDGE, 495 IDS_EXTENSIONS_ADDED_WITHOUT_KNOWLEDGE,
490 l10n_util::GetStringUTF16(IDS_EXTENSION_WEB_STORE_TITLE))); 496 l10n_util::GetStringUTF16(IDS_EXTENSION_WEB_STORE_TITLE)));
491 source->AddString("extensionSettingsLearnMore", 497 source->AddString("extensionSettingsLearnMore",
492 l10n_util::GetStringUTF16(IDS_LEARN_MORE)); 498 l10n_util::GetStringUTF16(IDS_LEARN_MORE));
493 source->AddString("extensionSettingsCorruptInstallHelpUrl", 499 source->AddString("extensionSettingsCorruptInstallHelpUrl",
494 base::ASCIIToUTF16(google_util::AppendGoogleLocaleParam( 500 base::ASCIIToUTF16(
495 GURL(chrome::kCorruptExtensionURL)).spec())); 501 google_util::AppendGoogleLocaleParam(
502 GURL(chrome::kCorruptExtensionURL),
503 g_browser_process->GetApplicationLocale()).spec()));
496 source->AddString("extensionSettingsSuspiciousInstallHelpUrl", 504 source->AddString("extensionSettingsSuspiciousInstallHelpUrl",
497 base::ASCIIToUTF16(google_util::AppendGoogleLocaleParam( 505 base::ASCIIToUTF16(
498 GURL(chrome::kRemoveNonCWSExtensionURL)).spec())); 506 google_util::AppendGoogleLocaleParam(
507 GURL(chrome::kRemoveNonCWSExtensionURL),
508 g_browser_process->GetApplicationLocale()).spec()));
499 source->AddString("extensionSettingsShowButton", 509 source->AddString("extensionSettingsShowButton",
500 l10n_util::GetStringUTF16(IDS_EXTENSIONS_SHOW_BUTTON)); 510 l10n_util::GetStringUTF16(IDS_EXTENSIONS_SHOW_BUTTON));
501 source->AddString("extensionSettingsLoadUnpackedButton", 511 source->AddString("extensionSettingsLoadUnpackedButton",
502 l10n_util::GetStringUTF16(IDS_EXTENSIONS_LOAD_UNPACKED_BUTTON)); 512 l10n_util::GetStringUTF16(IDS_EXTENSIONS_LOAD_UNPACKED_BUTTON));
503 source->AddString("extensionSettingsPackButton", 513 source->AddString("extensionSettingsPackButton",
504 l10n_util::GetStringUTF16(IDS_EXTENSIONS_PACK_BUTTON)); 514 l10n_util::GetStringUTF16(IDS_EXTENSIONS_PACK_BUTTON));
505 source->AddString("extensionSettingsCommandsLink", 515 source->AddString("extensionSettingsCommandsLink",
506 l10n_util::GetStringUTF16(IDS_EXTENSIONS_COMMANDS_CONFIGURE)); 516 l10n_util::GetStringUTF16(IDS_EXTENSIONS_COMMANDS_CONFIGURE));
507 source->AddString("extensionSettingsUpdateButton", 517 source->AddString("extensionSettingsUpdateButton",
508 l10n_util::GetStringUTF16(IDS_EXTENSIONS_UPDATE_BUTTON)); 518 l10n_util::GetStringUTF16(IDS_EXTENSIONS_UPDATE_BUTTON));
509 source->AddString( 519 source->AddString(
510 "extensionSettingsAppsDevToolsPromoHTML", 520 "extensionSettingsAppsDevToolsPromoHTML",
511 l10n_util::GetStringFUTF16( 521 l10n_util::GetStringFUTF16(
512 IDS_EXTENSIONS_APPS_DEV_TOOLS_PROMO_HTML, 522 IDS_EXTENSIONS_APPS_DEV_TOOLS_PROMO_HTML,
513 base::ASCIIToUTF16(google_util::AppendGoogleLocaleParam( 523 base::ASCIIToUTF16(
514 GURL(extension_urls::GetWebstoreItemDetailURLPrefix() + 524 google_util::AppendGoogleLocaleParam(
515 kAppsDeveloperToolsExtensionId)).spec()))); 525 GURL(extension_urls::GetWebstoreItemDetailURLPrefix() +
526 kAppsDeveloperToolsExtensionId),
527 g_browser_process->GetApplicationLocale()).spec())));
516 source->AddString( 528 source->AddString(
517 "extensionSettingsAppDevToolsPromoClose", 529 "extensionSettingsAppDevToolsPromoClose",
518 l10n_util::GetStringUTF16(IDS_CLOSE)); 530 l10n_util::GetStringUTF16(IDS_CLOSE));
519 source->AddString("extensionSettingsCrashMessage", 531 source->AddString("extensionSettingsCrashMessage",
520 l10n_util::GetStringUTF16(IDS_EXTENSIONS_CRASHED_EXTENSION)); 532 l10n_util::GetStringUTF16(IDS_EXTENSIONS_CRASHED_EXTENSION));
521 source->AddString("extensionSettingsInDevelopment", 533 source->AddString("extensionSettingsInDevelopment",
522 l10n_util::GetStringUTF16(IDS_EXTENSIONS_IN_DEVELOPMENT)); 534 l10n_util::GetStringUTF16(IDS_EXTENSIONS_IN_DEVELOPMENT));
523 source->AddString("extensionSettingsWarningsTitle", 535 source->AddString("extensionSettingsWarningsTitle",
524 l10n_util::GetStringUTF16(IDS_EXTENSION_WARNINGS_TITLE)); 536 l10n_util::GetStringUTF16(IDS_EXTENSION_WARNINGS_TITLE));
525 source->AddString("extensionSettingsShowDetails", 537 source->AddString("extensionSettingsShowDetails",
(...skipping 795 matching lines...) Expand 10 before | Expand all | Expand 10 after
1321 extension_service_->EnableExtension(extension_id); 1333 extension_service_->EnableExtension(extension_id);
1322 } else { 1334 } else {
1323 ExtensionErrorReporter::GetInstance()->ReportError( 1335 ExtensionErrorReporter::GetInstance()->ReportError(
1324 base::UTF8ToUTF16(JoinString(requirement_errors, ' ')), 1336 base::UTF8ToUTF16(JoinString(requirement_errors, ' ')),
1325 true); // Be noisy. 1337 true); // Be noisy.
1326 } 1338 }
1327 requirements_checker_.reset(); 1339 requirements_checker_.reset();
1328 } 1340 }
1329 1341
1330 } // namespace extensions 1342 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698