Change google_util::AppendGoogleLocaleParam to take in the application locale

Change google_util::AppendGoogleLocaleParam to take in the application locale

This function will be componentized, and hence cannot reference
g_browser_process.

BUG=373203
TBR=thakis

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276886

[blundell, 2014-06-10 20:44:18]

Here are the remaining callsites :).

[Peter Kasting, 2014-06-10 21:11:29]

The ones involving the Google URL tracker are only for a support article and
should go away as part of your other change, see comment there.

The rest of these we're going to have to find the owners of and ask people who
ultimately understand what's going on on the server.

I'm pretty sure in the end we should remove them all, that the Accept-Languages
header on the requests we send is the more reliable and effective way to do
this.  But I can't make that call myself.

[blundell, 2014-06-11 12:51:20]

On 2014/06/10 21:11:29, Peter Kasting wrote:
> The ones involving the Google URL tracker are only for a support article and
> should go away as part of your other change, see comment there.
> 
> The rest of these we're going to have to find the owners of and ask people who
> ultimately understand what's going on on the server.
> 
> I'm pretty sure in the end we should remove them all, that the
Accept-Languages
> header on the requests we send is the more reliable and effective way to do
> this.  But I can't make that call myself.

Thanks. Would you be OK landing this change to unblock google_util
componentization and filing bugs on owners to make those calls?

[Peter Kasting, 2014-06-11 18:23:26]

On 2014/06/11 12:51:20, blundell wrote:
> On 2014/06/10 21:11:29, Peter Kasting wrote:
> > The ones involving the Google URL tracker are only for a support article and
> > should go away as part of your other change, see comment there.
> > 
> > The rest of these we're going to have to find the owners of and ask people
who
> > ultimately understand what's going on on the server.
> > 
> > I'm pretty sure in the end we should remove them all, that the
> Accept-Languages
> > header on the requests we send is the more reliable and effective way to do
> > this.  But I can't make that call myself.
> 
> Thanks. Would you be OK landing this change to unblock google_util
> componentization and filing bugs on owners to make those calls?

How about land, and then write an update on the bug about removing the locale
param that notes the remaining locations here and says we need to investigate
eliminating them.

[Peter Kasting, 2014-06-11 18:25:54]

LGTM

https://codereview.chromium.org/327793005/diff/40001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/ntp/ntp_resource_cache.cc (right):

https://codereview.chromium.org/327793005/diff/40001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/ntp/ntp_resource_cache.cc:313:
localized_strings.SetString("learnMoreLink", GURL(new_tab_link).spec());
These next three places can drop the "GURL(x).spec()" and just do "x" instead,
as that transformation will be idempotent.

[blundell, 2014-06-12 16:12:36]

https://codereview.chromium.org/327793005/diff/40001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/ntp/ntp_resource_cache.cc (right):

https://codereview.chromium.org/327793005/diff/40001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/ntp/ntp_resource_cache.cc:313:
localized_strings.SetString("learnMoreLink", GURL(new_tab_link).spec());
On 2014/06/11 18:25:54, Peter Kasting wrote:
> These next three places can drop the "GURL(x).spec()" and just do "x" instead,
> as that transformation will be idempotent.

Done.

[blundell, 2014-06-12 16:13:34]

TBR=thakis for //chrome outside of //chrome/browser/google

[blundell, 2014-06-12 16:14:19]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-06-12 16:18:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/327793005/60001

[commit-bot: I haz the power, 2014-06-12 19:28:16]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[blundell, 2014-06-12 20:06:03]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-06-12 20:09:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/327793005/80001

[commit-bot: I haz the power, 2014-06-13 02:19:00]

Change committed as 276886