Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: chrome/browser/ui/webui/ntp/ntp_resource_cache.cc

Issue 327793005: Change google_util::AppendGoogleLocaleParam to take in the application locale (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ChromeOS fix Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
diff --git a/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc b/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
index 93bfbcd2868673e6ca65d8b2b41b9d69cabd8d2f..d335d9843a59f1d1e865a3f314bf258195da2240 100644
--- a/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
+++ b/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
@@ -310,7 +310,7 @@ void NTPResourceCache::CreateNewTabIncognitoHTML() {
localized_strings.SetString("learnMore",
l10n_util::GetStringUTF16(new_tab_link_ids));
- localized_strings.SetString("learnMoreLink", GURL(new_tab_link).spec());
+ localized_strings.SetString("learnMoreLink", new_tab_link);
bool bookmark_bar_attached = profile_->GetPrefs()->GetBoolean(
prefs::kShowBookmarkBar);
@@ -356,7 +356,7 @@ void NTPResourceCache::CreateNewTabGuestHTML() {
localized_strings.SetString("enterpriseLearnMore",
l10n_util::GetStringUTF16(IDS_LEARN_MORE));
localized_strings.SetString("enterpriseInfoHintLink",
- GURL(chrome::kLearnMoreEnterpriseURL).spec());
+ chrome::kLearnMoreEnterpriseURL);
} else {
localized_strings.SetString("enterpriseInfoVisible", "false");
}
@@ -368,8 +368,7 @@ void NTPResourceCache::CreateNewTabGuestHTML() {
l10n_util::GetStringUTF16(guest_tab_heading_ids));
localized_strings.SetString("learnMore",
l10n_util::GetStringUTF16(guest_tab_link_ids));
- localized_strings.SetString("learnMoreLink",
- GURL(guest_tab_link).spec());
+ localized_strings.SetString("learnMoreLink", guest_tab_link);
webui::SetFontAndTextDirection(&localized_strings);
@@ -459,7 +458,8 @@ void NTPResourceCache::CreateNewTabHTML() {
l10n_util::GetStringUTF16(IDS_LEARN_MORE));
load_time_data.SetString("webStoreLink",
google_util::AppendGoogleLocaleParam(
- GURL(extension_urls::GetWebstoreLaunchURL())).spec());
+ GURL(extension_urls::GetWebstoreLaunchURL()),
+ g_browser_process->GetApplicationLocale()).spec());
load_time_data.SetString("appInstallHintText",
l10n_util::GetStringUTF16(IDS_NEW_TAB_APP_INSTALL_HINT_LABEL));
load_time_data.SetBoolean("isDiscoveryInNTPEnabled",
« no previous file with comments | « chrome/browser/ui/webui/extensions/extension_settings_handler.cc ('k') | chrome/browser/ui/webui/sync_setup_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698