Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 327793002: Timeline: return 'null' from JSCallStack::asTraceFormat() when stack is absent (Closed)

Created:
6 years, 6 months ago by caseq
Modified:
6 years, 6 months ago
Reviewers:
yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Timeline: return 'null' from JSCallStack::asTraceFormat() when stack is absent Timeline front-end used to assume that if call stack is present, it contains at least one call frame. Let's not break that expectation when transitioning to trace-based instrumentation and return null, not empty array, for the absent stack. BUG=361045 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175898

Patch Set 1 #

Patch Set 2 : also fix front-end #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/inspector/InspectorTraceEvents.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineModel.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
caseq
6 years, 6 months ago (2014-06-10 11:56:57 UTC) #1
yurys
Is there a scenario where we can see the difference in behavior because of this ...
6 years, 6 months ago (2014-06-10 11:58:47 UTC) #2
caseq
On 2014/06/10 11:58:47, yurys wrote: > Is there a scenario where we can see the ...
6 years, 6 months ago (2014-06-10 12:01:48 UTC) #3
yurys
lgtm
6 years, 6 months ago (2014-06-10 12:33:49 UTC) #4
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 6 months ago (2014-06-10 12:38:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/327793002/20001
6 years, 6 months ago (2014-06-10 12:38:53 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-10 14:31:25 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 15:32:33 UTC) #8
Message was sent while issue was closed.
Change committed as 175898

Powered by Google App Engine
This is Rietveld 408576698