Source/devtools/front_end/timeline/TracingTimelineModel.js - Issue 327793002: Timeline: return 'null' from JSCallStack::asTraceFormat() when stack is absent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/TracingTimelineModel.js

Issue 327793002: Timeline: return 'null' from JSCallStack::asTraceFormat() when stack is absent (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: also fix front-end Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/devtools/front_end/timeline/TracingTimelineModel.js

diff --git a/Source/devtools/front_end/timeline/TracingTimelineModel.js b/Source/devtools/front_end/timeline/TracingTimelineModel.js

index a81f065b0ef5c9a388d78203753365a94ee7c9aa..b2de33f635ee6dc754b18ef87d32c5f22fd76bff 100644

--- a/Source/devtools/front_end/timeline/TracingTimelineModel.js

+++ b/Source/devtools/front_end/timeline/TracingTimelineModel.js

@@ -310,7 +310,7 @@ WebInspector.TracingTimelineModel.prototype = {

switch (event.name) {

case recordTypes.CallStack:

var lastMainThreadEvent = this._mainThreadEvents.peekLast();

- if (lastMainThreadEvent)

+ if (lastMainThreadEvent && event.args.stack && event.args.stack.length)

lastMainThreadEvent.stackTrace = event.args.stack;

break;

« no previous file with comments | « Source/core/inspector/InspectorTraceEvents.cpp ('k') | no next file » | no next file with comments »