sync/test/fake_server/fake_server_entity.cc - Issue 327593003: Sync FakeServer cleanup: CHECKs and logging info

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/test/fake_server/fake_server_entity.cc

Issue 327593003: Sync FakeServer cleanup: CHECKs and logging info (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/test/fake_server/fake_server_entity.cc

diff --git a/sync/test/fake_server/fake_server_entity.cc b/sync/test/fake_server/fake_server_entity.cc

index 4d96a805dc53724cacdd3f435020f9b302acfe90..7b407f94880573d342abf93cf582a54c65e2e2d1 100644

--- a/sync/test/fake_server/fake_server_entity.cc

+++ b/sync/test/fake_server/fake_server_entity.cc

@@ -87,7 +87,7 @@ FakeServerEntity::FakeServerEntity(const string& id,

void FakeServerEntity::SerializeBaseProtoFields(

sync_pb::SyncEntity* sync_entity) {

- DCHECK(sync_entity);

+ CHECK(sync_entity);

rlarocque 2014/06/09 21:28:48 See CL-level comment.

pval...(no longer on Chromium) 2014/06/09 23:29:27 sounds good. removed.

// FakeServerEntity fields

sync_entity->set_id_string(id_);