Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 327483002: Removed unused toV8Value and createFromV8Value from WebArrayBufferConverter. (Closed)

Created:
6 years, 6 months ago by tasak
Modified:
6 years, 6 months ago
Reviewers:
haraken, tkent
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

Removed unused toV8Value and createFromV8Value from WebArrayBufferConverter. Since r276361 made chromium side not to use the methods, now we can remove these methods from Blink. c.f. https://codereview.chromium.org/301883002 and svn://svn.chromium.org/chrome/trunk/src@276361 BUG=369451 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176187

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M Source/web/WebArrayBufferConverter.cpp View 2 chunks +0 lines, -15 lines 0 comments Download
M public/web/WebArrayBufferConverter.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tasak
Would you review this CL?
6 years, 6 months ago (2014-06-16 08:13:36 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-16 08:15:48 UTC) #2
tkent
lgtm
6 years, 6 months ago (2014-06-16 08:25:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/327483002/20001
6 years, 6 months ago (2014-06-16 08:26:36 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 08:35:04 UTC) #5
Message was sent while issue was closed.
Change committed as 176187

Powered by Google App Engine
This is Rietveld 408576698