Should provide creation context and isolate for WebArrayConverter

Should provide creation context and isolate for WebArrayConverter::toV8Value and WebArrayConverter::createFromV8Value.

BUG=369451
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276361

[tasak, 2014-06-09 08:11:28]

Would you review this CL?

[haraken, 2014-06-09 09:05:52]

LGTM

[tasak, 2014-06-09 09:27:17]

darin, would you review this CL?

[darin (slow to review), 2014-06-10 04:52:02]

https://codereview.chromium.org/301883002/diff/20001/content/renderer/v8_valu...
File content/renderer/v8_value_converter_impl.cc (right):

https://codereview.chromium.org/301883002/diff/20001/content/renderer/v8_valu...
content/renderer/v8_value_converter_impl.cc:171: v8::Handle<v8::Object>
creationContext,
ditto... there are more. please fix-up code to match google c++ style guide.

https://codereview.chromium.org/301883002/diff/20001/content/renderer/v8_valu...
File content/renderer/v8_value_converter_impl.h (right):

https://codereview.chromium.org/301883002/diff/20001/content/renderer/v8_valu...
content/renderer/v8_value_converter_impl.h:47: v8::Handle<v8::Object>
creationContext,
nit: creation_context

https://codereview.chromium.org/301883002/diff/20001/content/renderer/v8_valu...
content/renderer/v8_value_converter_impl.h:50: v8::Handle<v8::Object>
creationContext,
ditto

https://codereview.chromium.org/301883002/diff/20001/content/renderer/v8_valu...
content/renderer/v8_value_converter_impl.h:57: v8::Handle<v8::Object>
creationContext,
ditto

[tasak, 2014-06-10 05:09:15]

Thank you for reviewing.

And I'm sorry for checking coding style issue.

https://codereview.chromium.org/301883002/diff/20001/content/renderer/v8_valu...
File content/renderer/v8_value_converter_impl.cc (right):

https://codereview.chromium.org/301883002/diff/20001/content/renderer/v8_valu...
content/renderer/v8_value_converter_impl.cc:171: v8::Handle<v8::Object>
creationContext,
On 2014/06/10 04:52:01, darin wrote:
> ditto... there are more. please fix-up code to match google c++ style guide.

Done.

https://codereview.chromium.org/301883002/diff/20001/content/renderer/v8_valu...
File content/renderer/v8_value_converter_impl.h (right):

https://codereview.chromium.org/301883002/diff/20001/content/renderer/v8_valu...
content/renderer/v8_value_converter_impl.h:47: v8::Handle<v8::Object>
creationContext,
On 2014/06/10 04:52:01, darin wrote:
> nit: creation_context

Done.

https://codereview.chromium.org/301883002/diff/20001/content/renderer/v8_valu...
content/renderer/v8_value_converter_impl.h:50: v8::Handle<v8::Object>
creationContext,
On 2014/06/10 04:52:01, darin wrote:
> ditto

Done.

https://codereview.chromium.org/301883002/diff/20001/content/renderer/v8_valu...
content/renderer/v8_value_converter_impl.h:57: v8::Handle<v8::Object>
creationContext,
On 2014/06/10 04:52:01, darin wrote:
> ditto

Done.

[tasak, 2014-06-10 05:13:54]

On 2014/06/10 05:09:15, tasak wrote:
> Thank you for reviewing.
> 
> And I'm sorry for checking coding style issue.

I'm sorry for taking your time for checking my bad coding style.

[jamesr, 2014-06-10 18:02:15]

lgtm

[tasak, 2014-06-11 01:07:46]

On 2014/06/10 18:02:15, jamesr wrote:
> lgtm

Thank you.

[tasak, 2014-06-11 01:07:51]

The CQ bit was checked by tasak@google.com

[commit-bot: I haz the power, 2014-06-11 01:09:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tasak@google.com/301883002/40001

[commit-bot: I haz the power, 2014-06-11 12:15:53]

Change committed as 276361