Move server logging to rebaseline-o-matic.

Move server logging to rebaseline-o-matic.

It didn't really make sense to be part of auto-rebaseline except
for the special noneedsrebaseline entries, which I've decided are
not really useful anyways. More importantly, move it up means
that we actually log everything to the server, including the outer
git pull call and it means that we log asynchronously to the
auto-rebaseline command, which should make it a lot faster.

Also, make the git cl upload logging log stderr as well.

BUG=382248
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175828

[Dirk Pranke, 2014-06-09 19:30:32]

lgtm. Basically seems fine. A couple of minor suggestions ...

https://codereview.chromium.org/327443002/diff/1/Tools/Scripts/webkitpy/tool/...
File Tools/Scripts/webkitpy/tool/commands/rebaseline.py (right):

https://codereview.chromium.org/327443002/diff/1/Tools/Scripts/webkitpy/tool/...
Tools/Scripts/webkitpy/tool/commands/rebaseline.py:879: def
_run_logging_command(self, command):
nit: I might call this "run_logged_command" instead, since you're running the
command and doing something with the logging. "run_logging_command" sounds to me
like you're running a command that has something to do w/ logging, like turning
it on or something.

I might also separate out the running of the command from the uploading of the
logs. e.g.:

out, err = self._run_command()
self._upload_logs(out)
self._upload_logs(err)

or some such.

[ojan, 2014-06-09 21:15:10]

https://codereview.chromium.org/327443002/diff/1/Tools/Scripts/webkitpy/tool/...
File Tools/Scripts/webkitpy/tool/commands/rebaseline.py (right):

https://codereview.chromium.org/327443002/diff/1/Tools/Scripts/webkitpy/tool/...
Tools/Scripts/webkitpy/tool/commands/rebaseline.py:879: def
_run_logging_command(self, command):
On 2014/06/09 19:30:31, Dirk Pranke wrote:
> nit: I might call this "run_logged_command" instead, since you're running the
> command and doing something with the logging. "run_logging_command" sounds to
me
> like you're running a command that has something to do w/ logging, like
turning
> it on or something.

Done.

> I might also separate out the running of the command from the uploading of the
> logs. e.g.:
> 
> out, err = self._run_command()
> self._upload_logs(out)
> self._upload_logs(err)
> 
> or some such.

I want it to upload incrementally as the command is going. Not sure how to do
that with this suggestion.

[commit-bot: I haz the power, 2014-06-09 21:16:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ojan@chromium.org/327443002/20001

[commit-bot: I haz the power, 2014-06-09 22:23:56]

Change committed as 175828