Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1638)

Unified Diff: Tools/RebaselineLogServer/main.py

Issue 327443002: Move server logging to rebaseline-o-matic. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: do rename Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/tool/commands/rebaseline.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/RebaselineLogServer/main.py
diff --git a/Tools/RebaselineLogServer/main.py b/Tools/RebaselineLogServer/main.py
index 734fc9908b76ba5d57fdbcc2af243206fca658e2..296e776fc2742baa4822774441db2fe04f79f130 100644
--- a/Tools/RebaselineLogServer/main.py
+++ b/Tools/RebaselineLogServer/main.py
@@ -47,6 +47,8 @@ from google.appengine.ext.db import BadRequestError
LOG_PARAM = "log"
NEW_ENTRY_PARAM = "newentry"
+# FIXME: no_needs_rebaseline is never used anymore. Remove support for it.
+# Instead, add UI to logs.html to collapse short entries.
NO_NEEDS_REBASELINE_PARAM = "noneedsrebaseline"
NUM_LOGS_PARAM = "numlogs"
BEFORE_PARAM = "before"
@@ -74,6 +76,7 @@ class UpdateLog(webapp2.RequestHandler):
# avoid cluttering the log with useless empty posts. It just updates the
# date of the entry so that users can see that rebaseline-o-matic is still
# running.
+ # FIXME: no_needs_rebaseline is never used anymore. Remove support for it.
no_needs_rebaseline = self.request.POST.get(NO_NEEDS_REBASELINE_PARAM) == "on"
out = "Wrote new log entry."
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/tool/commands/rebaseline.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698