Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Issue 327423006: Revert r276792 - "Hook PushMessagingMessageFilter up to GCMDriver" (Closed)

Created:
6 years, 6 months ago by Dirk Pranke
Modified:
6 years, 6 months ago
Reviewers:
johnme
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, asanka, creis+watch_chromium.org, benjhayden+dwatch_chromium.org, tfarina, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, android-webview-reviews_chromium.org, jochen+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert r276792 - "Hook PushMessagingMessageFilter up to GCMDriver" This change caused the sole push_messaging layout test to fail :(. > Hook PushMessagingMessageFilter up to GCMDriver > > Add plumbing for registration from push service-agnostic content layer > to GCMDriver in chrome layer. > > To achieve this, GCMProfileService owns an implementation of a new > PushMessagingService class, which can be used from the content layer. > > Based on mvanouwerkerk's prototype in https://codereview.chromium.org/186023002, but significantly refactored. > > BUG=350384 > TBR=benm@chromium.org TBR=johnme@chromium.org BUG=350384 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276834

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -245 lines) Patch
M android_webview/browser/aw_browser_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/browser/aw_browser_context.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service.h View 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service.cc View 3 chunks +3 lines, -7 lines 0 comments Download
D chrome/browser/services/gcm/push_messaging_service_impl.h View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/services/gcm/push_messaging_service_impl.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/test/fake_profile.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/base/testing_profile.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/testing_profile.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/download/download_manager_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/push_messaging_message_filter.h View 2 chunks +1 line, -15 lines 0 comments Download
M content/browser/push_messaging_message_filter.cc View 3 chunks +9 lines, -41 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/browser_context.h View 2 chunks +0 lines, -6 lines 0 comments Download
D content/public/browser/push_messaging_service.h View 1 chunk +0 lines, -33 lines 0 comments Download
M content/public/test/test_browser_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/test_browser_context.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/browser/shell_browser_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/shell_browser_context.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dirk Pranke
Committed patchset #1 manually as r276834 (presubmit successful).
6 years, 6 months ago (2014-06-12 22:44:58 UTC) #1
Dirk Pranke
6 years, 6 months ago (2014-06-12 23:02:45 UTC) #2

Powered by Google App Engine
This is Rietveld 408576698